[script.module.t1mlib] 4.0.8

[sanpoChew]

Description

Update t1mlib to use xbmcfvs.translatePath instead of removed method xbmx.translatePath
(Method was removed here xbmc/xbmc#19301)

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practise but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.

[enen92]

Ping @learningit

[learningit]

I'm perfectly ok with this but I don't think it fixes all the problems. I was stuck in China during COVID (nearly a year and a half) and have only returned to the US a couple weeks ago. My apologies that I haven't got around to fixes for the lib and my add-ons for Nexus. For the lib to work a fix also needs to be put in for html.parser.unescape. I'm fine with this PR for the repo but I don't think it will work on Android. I'll try to look at any other needed changes over the next week or so.

[sanpoChew]

I'm perfectly ok with this but I don't think it fixes all the problems. I was stuck in China during COVID (nearly a year and a half) and have only returned to the US a couple weeks ago. My apologies that I haven't got around to fixes for the lib and my add-ons for Nexus. For the lib to work a fix also needs to be put in for html.parser.unescape. I'm fine with this PR for the repo but I don't think it will work on Android. I'll try to look at any other needed changes over the next week or so.

ah yeah unescape changes were mentioned on this post that I came across but it wasn't throwing an error for me on a raspberry pi so I left it.

If you'd rather open your own PR that works, I was just thinking I'd surface the problem a bit more with a PR rather than the way people are doing it manually on the forum.

the initial forum post in the NHK Live plugin thread that lead me to that comment

[basrieter]

Why not update the Matrix version script.module.t1mlib-4.0.7?

At the moment, because you target <import addon="xbmc.python" version="3.0.0" /> it will be compatible with Matrix, Nexus and Omega. If you update it in the Matrix repo it will be available in Matrix and up.

With this PR, the update will only be available in Nexus, not Matrix.

[sanpoChew]

Why not update the Matrix version script.module.t1mlib-4.0.7?

At the moment, because you target <import addon="xbmc.python" version="3.0.0" /> it will be compatible with Matrix, Nexus and Omega. If you update it in the Matrix repo it will be available in Matrix and up.

With this PR, the update will only be available in Nexus, not Matrix.

Ah, that's just an oversight by me then, I didn't realise that if you update Matrix it is available in Matrix and up, I see it in the Additional Information in the PR template now.

I've opened a new PR #2443 against nexus and added in the html.parser.unescape change also.

[learningit]

I've added a pull request to update the script.module.t1mlib in the nexus branch.
I believe that if you put the changes in the matrix branch you need to check the python version and possibly the platform being used. I seem to recall that Android had a different version of python from Windows or Linux at one point.