Reactive Current Locale

[sylvano-tombo]

Add reactive current locale - Related to this #192

[rottifant]

I have just looked to see if there is a way to reactively retrieve the current language and have now discovered this PR.
Looks good.
Would be great if this could be merged asap :)

[rottifant]

@xiCO2k, are there any plans to merge this PR soon?

[xiCO2k]

Thanks for that.

[tcytra]

I believe this broke something. Prior to this I was using loadLanguageAsync() to switch locales and getActiveLanguage() would detect the change, Now it always returns the original html lang. The languages do switch, loadLanguageAsync() works, but after switching locales getActiveLanguage() doesn't detect the change. I'm going to need to freeze this at the previous version.

[sylvano-tombo]

I believe this broke something. Prior to this I was using loadLanguageAsync() to switch locales and getActiveLanguage() would detect the change, Now it always returns the original html lang. The languages do switch, loadLanguageAsync() works, but after switching locales getActiveLanguage() doesn't detect the change. I'm going to need to freeze this at the previous version.

Hi @tcytra,

Could you provide a sample to reproduce the issue? This change shouldn’t affect anything else—it simply sets currentLanguage, which maintains its own value. All tests involving loadLanguageAsync() and getActiveLanguage() are passing on my end.

Maybe you forgot the await in loadLanguageAsync before calling getActiveLanguage()?

[tcytra]

Thanks for the response. I revisited this morning and (without changing anything) it's working for me again. I don't know why it stopped working or why it started working again. My apologies for a false alarm.

[Fuzzyma]

Just saw this change in the release (thx!). But this part here is incorrect.
Whenever the locale change, you call getCurrentLanguage() (because its in the computed). and that method creates a new computed, returns it and you grab the value from it. By definition, computeds should never be recreated inside another computed.

So the correct approach here would be to simply use the computed directly:

export const currentLocale = I18n.getSharedInstance().getCurrentLanguage()

(You also wouldnt write computed(() => computed(() => something).value))