-
Notifications
You must be signed in to change notification settings - Fork 184
v1.9.0 creates invalid json by including undefined values #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Closing this as I guess it's intentional that this lib creates a superset of json |
Could you reopen as this looks like a breaking change that might have warranted a major version bump. |
I just released v1.9.1 (includes reverting #54) and v2.0.0 for this issue. Thanks! |
Thanks for the quick fix @okuryu ! |
1 task
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There seems to be a regression in v1.9.0 where objects with undefined values are being included in the json output, which is invalid. For example:
Output:
This is not valid json, and will fail when run through
JSON.parse()
In v1.8.0 this worked correctly with the following output:
The text was updated successfully, but these errors were encountered: