-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
fix: serialize-javascript vulnerability by updating package (#10910) #10911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove all generated files related changes and only include package.json files changes, please?
Note: there is a breaking change regarding how objects with an
when squashing |
|
Please check again. My history got a bit hairy with the revert. If this PR is still broken I will close and open a clean PR without running the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only package.json files must end up modified. Feel free to submit a new PR if that's easier for you
Problem is I'll have to --no-verify passed the linter as it seems to correct some issues on commit, is this acceptable? |
it shouldn't be a problem but yes, you can do that and the PR might still be valid |
Closing in favor of #10914 |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: