test: don't hardcode timeout interval and don't rely on jasmine #4646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
#4543 hardcoded the timeout interval, but it has already gotten out of sync due to #3669.
How did you fix it?
Made it useExtracted the timeout tojasmine.DEFAULT_TIMEOUT_INTERVAL
pkg-tests-core
and removed usage ofjasmine.DEFAULT_TIMEOUT_INTERVAL
to make it easier for us to switch tojest-circus
, the new jest runner.I also added a
TODO
so that we don't forget to recheck whether this is still needed. (I have a feeling that the big-endian PR might've fixed all timeout issues).Checklist