Skip to content

Add Gentoo Linux install instructions #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Add Gentoo Linux install instructions #935

merged 2 commits into from
Mar 26, 2019

Conversation

bigfootjon
Copy link
Contributor

Yarn is available on Gentoo's portage package manager (1), and I
have a pending patch to yarn to provide correct install instructions
from within the yarn cli (2).

(1) https://packages.gentoo.org/packages/sys-apps/yarn
(2) yarnpkg/yarn#7123

@DanBuild
Copy link
Contributor

DanBuild commented Mar 18, 2019

Deploy preview for yarnpkg ready!

Built with commit 3ebedb2

https://deploy-preview-935--yarnpkg.netlify.com

@Haroenv
Copy link
Member

Haroenv commented Mar 18, 2019

looks like we will need a fallback for languages not yet translated here too, like for install-ci

@bigfootjon
Copy link
Contributor Author

@Haroenv are you referring to the file_exists tag? (added in fe50d77)

@Haroenv
Copy link
Member

Haroenv commented Mar 18, 2019

Yes, it's a bit of a hacky workaround, but is needed because of the i18n implementation

@bigfootjon
Copy link
Contributor Author

Well the build succeeds now but the deploy preview doesn't show any install instructions. @Haroenv Is this expected?

@Haroenv
Copy link
Member

Haroenv commented Mar 20, 2019

That's not expected, and likely an error in the (fairly hacky) workaround for missing files. Unfortunately I don't really have time to look into this right now

Yarn is available on Gentoo's portage package manager (1), and I
have a pending patch to yarn to provide correct install instructions
from within the yarn cli (2).

(1) https://packages.gentoo.org/packages/sys-apps/yarn
(2) yarnpkg/yarn#7123
@bigfootjon
Copy link
Contributor Author

I was able to fix the missing install documentation. Turned out to be a flaw with the implementation of file_exists where it didn't strip trailing whitespace, I've inserted a commit to fix that but if you would rather I can split it out into a separate PR or I can rewrite my changes to match the style of the other use of file_exists (i.e. without whitespace around the file path)

@Haroenv Haroenv merged commit fbdecc1 into yarnpkg:master Mar 26, 2019
@Haroenv
Copy link
Member

Haroenv commented Mar 26, 2019

Thanks for the effort you put in this!ç

@bigfootjon bigfootjon deleted the add-gentoo-install branch March 26, 2019 12:25
@bigfootjon
Copy link
Contributor Author

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants