Status bar logged to console after completion message #4023
Assignees
Labels
Comments
|
Can this be the solution: #4067 |
|
Just tried with the latest commit from master and it's still showing the additional output. |
|
Alright, will check again tomorrow and see if I can repro. |
|
@aracarie - Looks like this was an existing issue, masked by the previously used |
BYK
pushed a commit
that referenced
this issue
Aug 3, 2017
**Summary** Fixes #4023. There was nothing preventing the console reporter from having more than one progress bars, or keep updating and rendering its progress bar after it was finished or the reporter was "done". This patch stores the active progress bar, and stops it before `footer` is printed out. Also makes sure the progress bar itself ignores any updates once it stops. **Test plan** One, weak, existing test with updated snapshot. Manual steps: - Run `yarn install express` - Observe that your console is properly cleared after `yarn` finishes and the last thing you see is the "Done in X.YZs." message and not a corrupted progress bar.
BYK
added a commit
that referenced
this issue
Aug 4, 2017
**Summary** Fixes #4023. There was nothing preventing the console reporter from having more than one progress bars, or keep updating and rendering its progress bar after it was finished or the reporter was "done". This patch stores the active progress bar, and stops it before `footer` is printed out. Also makes sure the progress bar itself ignores any updates once it stops. **Test plan** One, weak, existing test with updated snapshot. Manual steps: - Run `yarn install express` - Observe that your console is properly cleared after `yarn` finishes and the last thing you see is the "Done in X.YZs." message and not a corrupted progress bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Status bar logged to console after completion message is printed.
If the current behavior is a bug, please provide the steps to reproduce.
Use latest yarn from master for this:
You'll see items being logged after the completion message "Done in Xs" is printed. I think it's related to commit 61e402b where
process.exit()was changed out forprocess.exitCode;What is the expected behavior?
Completion message is the final thing printed.
Please mention your node.js, yarn and operating system version.
Node.js v6.11.0 / Yarn latest commit
The text was updated successfully, but these errors were encountered: