-
Notifications
You must be signed in to change notification settings - Fork 3
YDBDOCS-668: add a playbook to show node logs #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,28 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should put this playbook here https://github.com/ydb-platform/ydb-ansible/tree/main/playbooks
to avoid duplicate code and to be able to use it with any project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artgromov then why do we have setup_playbook.yaml
copy-pasted to all examples? How people are supposed to discover the playbooks in that folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artgromov then why do we have setup_playbook.yaml copy-pasted to all examples?
I dont know, they seem excessive to me.
How people are supposed to discover the playbooks in that folder?
Only by reading collection documentation, which is absent for now.
That is the usual way for ansible collections. By making people copy-pasting example playbooks we are loosing maintainability for user-deployed systems. If we want to guarantee service continuity while using our playbooks, we should distribute them with ydb_platform collection and should heavily use various asserts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artgromov ok, so it sounds like a plan:
- Here's a copy of this PR in that other repo: YDBDOCS-668: add a playbook to show node logs ydb-ansible#19
- We'll need to update the documentation so all users end up with Ansible 2.11+ (currently, I got 2.10 by following them on Ubuntu 22.04, and the steps below don't work)
- Recommend people to use playbooks from our collection via https://docs.ansible.com/ansible/latest/collections_guide/collections_using_playbooks.html#using-a-playbook-from-a-collection (and move setup_playbook.yaml there as well)
- Document other available playbooks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy of setup_playbook.yaml ydb-platform/ydb-ansible#20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvement of instructions to lower the chance of people accidentally ending up with an old Ansible version like I did: https://github.com/ydb-platform/ydb/pull/4394/files
Discarding this PR in favor of ydb-platform/ydb-ansible#19. Playbook from the collection could be invoked using command:
|
No description provided.