Skip to content

Refactored operation id #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions include/ydb-cpp-sdk/library/operation_id/operation_id.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@
#include <memory>
#include <string>
#include <vector>
#include <unordered_map>

namespace Ydb {
class TOperationId;
}

namespace NKikimr {
namespace NOperationId {

class TOperationId {
static constexpr int kEKindMinValue = 0;
static constexpr int kEKindMaxValue = 10;
public:
enum EKind : int {
UNUSED = 0,
Expand All @@ -31,40 +32,38 @@ class TOperationId {
std::string Value;
};

using TDataList = std::vector<std::unique_ptr<TData>>;

TOperationId();
explicit TOperationId(const std::string& string, bool allowEmpty = false);

TOperationId(const TOperationId& other);
TOperationId(TOperationId&& other) = default;
TOperationId(TOperationId&& other);

TOperationId& operator=(const TOperationId& other);
TOperationId& operator=(TOperationId&& other) = default;
TOperationId& operator=(TOperationId&& other);

~TOperationId() = default;
~TOperationId();

EKind GetKind() const;
void SetKind(const EKind& kind);

const TDataList& GetData() const;
TDataList& GetMutableData();
std::vector<TData> GetData() const;

void AddOptionalValue(const std::string& key, const std::string& value);
const std::vector<const std::string*>& GetValue(const std::string& key) const;

std::string GetSubKind() const;
std::string ToString() const;

const Ydb::TOperationId& GetProto() const;
private:
bool IsValidKind(int kind);
void CopyData(const TOperationId::TDataList& otherData);

EKind Kind;
TDataList Data;
std::unordered_map<std::string, std::vector<const std::string*>> Index;
class TImpl;
std::unique_ptr<TImpl> Impl;
};

void AddOptionalValue(TOperationId& operarionId, const std::string& key, const std::string& value);
void AddOptionalValue(TOperationId& operarionId, const std::string& key, const char* value, size_t size);
std::string ProtoToString(const Ydb::TOperationId& proto);

void AddOptionalValue(Ydb::TOperationId& operarionId, const std::string& key, const std::string& value);

TOperationId::EKind ParseKind(const std::string_view value);

std::string FormatPreparedQueryIdCompat(const std::string& str);
Expand Down
3 changes: 3 additions & 0 deletions src/library/operation_id/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
add_subdirectory(protos)

_ydb_sdk_add_library(library-operation_id)

target_link_libraries(library-operation_id
PRIVATE
yutil
cgiparam
uri
lib-operation_id-protos
)

target_sources(library-operation_id PRIVATE
Expand Down
Loading
Loading