Removed query id in prepare statement #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyakharev
changed the title
rekby
reviewed
May 24, 2023
src/Session.php
Outdated
| @@ -359,7 +359,7 @@ public function query($yql, array $parameters = null) | |||
| $query = $this->newQuery($yql) | |||
| ->parameters($parameters) | |||
| ->txControl($tx_control) | |||
| ->keepInCache($this->keep_query_in_cache); | |||
| ->keepInCache($this->keep_query_in_cache || ($parameters&&count($parameters)>0)); | |||
There was a problem hiding this comment.
Need check about flag keep_query_in_cache exists.
if keep_query_in_cache is null - use autoset of flag (by parameters count)
if keep_query_in_cache is not null - use value of the flag, without check parameters count.
src/Session.php
Outdated
| @@ -416,20 +416,11 @@ public function prepare($yql) | |||
| { | |||
| $statement = new Statement($this, $yql); | |||
|
|
|||
There was a problem hiding this comment.
Remove cache will dramatically decreasy perforemance, because SDK will go to server for prepare every time.
I suggest save cache of metadata if any of them need to execute query of replace prepare to stub if nothing need for execute query.
rekby
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Close #59