avoid changing shardstate reads list during iteration (#12150) (#12170)

gridnevvvit · ssmike · web-flow · commit 9ea17dd06cb2 · 2024-12-02T12:45:28.000+03:00
Co-authored-by: Mikhail Surin &lt;ssmike@ydb.tech&gt;
diff --git a/ydb/core/kqp/runtime/kqp_stream_lookup_actor.cpp b/ydb/core/kqp/runtime/kqp_stream_lookup_actor.cpp
@@ -413,12 +413,16 @@ class TKqpStreamLookupActor : public NActors::TActorBootstrapped<TKqpStreamLooku
         auto shardIt = ReadsPerShard.find(tabletId);
         YQL_ENSURE(shardIt != ReadsPerShard.end());
 
+        TVector<TReadState*> toRetry;
         for (auto* read : shardIt->second.Reads) {
             if (read->State == EReadState::Running) {
                 Counters->IteratorDeliveryProblems->Inc();
-                RetryTableRead(*read);
+                toRetry.push_back(read);
             }
         }
+        for (auto* read : toRetry) {
+            RetryTableRead(*read);
+        }
     }
 
     void Handle(TEvPrivate::TEvSchemeCacheRequestTimeout::TPtr&) {

Original file line number	Diff line number	Diff line change
`@@ -413,12 +413,16 @@ class TKqpStreamLookupActor : public NActors::TActorBootstrapped<TKqpStreamLooku`
`413`	`413`	`auto shardIt = ReadsPerShard.find(tabletId);`
`414`	`414`	`YQL_ENSURE(shardIt != ReadsPerShard.end());`
`415`	`415`
	`416`	`+ TVector<TReadState*> toRetry;`
`416`	`417`	`for (auto* read : shardIt->second.Reads) {`
`417`	`418`	`if (read->State == EReadState::Running) {`
`418`	`419`	`Counters->IteratorDeliveryProblems->Inc();`
`419`		`- RetryTableRead(*read);`
	`420`	`+ toRetry.push_back(read);`
`420`	`421`	`}`
`421`	`422`	`}`
	`423`	`+ for (auto* read : toRetry) {`
	`424`	`+ RetryTableRead(*read);`
	`425`	`+ }`
`422`	`426`	`}`
`423`	`427`
`424`	`428`	`void Handle(TEvPrivate::TEvSchemeCacheRequestTimeout::TPtr&) {`