Skip to content

avoid changing shardstate reads list during iteration (#12150) #12170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gridnevvvit
Copy link
Member

Changelog entry

avoid changing shardstate reads list during iteration (#12150)

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@gridnevvvit gridnevvvit requested a review from a team as a code owner December 1, 2024 22:24
Copy link

github-actions bot commented Dec 1, 2024

2024-12-01 22:26:01 UTC Pre-commit check for 820fa73 has started.
2024-12-01 22:28:37 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-12-01 22:35:12 UTC Build successful.

Copy link

github-actions bot commented Dec 1, 2024

2024-12-01 22:28:13 UTC Pre-commit check for 820fa73 has started.
2024-12-01 22:30:48 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-01 23:09:55 UTC Build successful.
2024-12-01 23:10:14 UTC Tests are running...
🔴 2024-12-02 00:37:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14670 13321 0 10 1300 39

🟢 2024-12-02 00:37:57 UTC ydbd size 8.3 GiB changed* by +12.2 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: c3d51bf merge: 820fa73 diff diff %
ydbd size 8 868 181 568 Bytes 8 868 194 096 Bytes +12.2 KiB +0.000%
ydbd stripped size 484 082 024 Bytes 484 082 664 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 1, 2024

2024-12-01 22:28:22 UTC Pre-commit check for 820fa73 has started.
2024-12-01 22:31:04 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-01 22:54:55 UTC Build successful.
2024-12-01 22:55:20 UTC Tests are running...
🔴 2024-12-02 01:06:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10345 10250 0 26 26 43

🟢 2024-12-02 01:06:58 UTC ydbd size 5.6 GiB changed* by +4.5 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: c3d51bf merge: 820fa73 diff diff %
ydbd size 5 998 658 928 Bytes 5 998 663 536 Bytes +4.5 KiB +0.000%
ydbd stripped size 1 503 259 840 Bytes 1 503 260 608 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit merged commit 9ea17dd into ydb-platform:stable-24-3 Dec 2, 2024
8 of 12 checks passed
@gridnevvvit gridnevvvit deleted the stream-lookup-bug-fix branch February 25, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants