Skip to content

Make the Row Count great again (correct in stats) #15105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hor911 opened this issue Feb 27, 2025 · 0 comments
Closed

Make the Row Count great again (correct in stats) #15105

Hor911 opened this issue Feb 27, 2025 · 0 comments
Assignees
@Hor911

Comments

@Hor911
Copy link
Collaborator

Hor911 commented Feb 27, 2025 •
edited
Loading

After block computing introduction row counters are mixed up with block counters and are not correct

We need exact row counters for statistics, result limits etc.

For history

  1. First attempt Correct Rows count in Block Output Channels #11893 was incorrect, caused data loss on update in mixed (old+new) environment and reverted Revert "Correct Rows count in Block Output Channels (#11893)" #13285
  2. Second PR Correct Rows count in Block Output Channels #14502 was tested and looks correct, but still confusing
  3. And finally we agreed to break changed to few PRs:
    Rename RowCount => ChunkCount to align with semantics and make it less confusing #15080
    Add RowsCount/Rows and use it for stats purposes #15629
    Fix Push stats (update it before deserialization) for InputChannels #16063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hor911 Hor911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Hor911