Skip to content

Correct Rows count in Block Output Channels #14502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented Feb 12, 2025

No description provided.

@Hor911 Hor911 requested review from a team as code owners February 12, 2025 17:03
Copy link

github-actions bot commented Feb 12, 2025

2025-02-12 17:05:08 UTC Pre-commit check linux-x86_64-release-asan for c038682 has started.
2025-02-12 17:05:37 UTC Artifacts will be uploaded here
2025-02-12 17:09:12 UTC ya make is running...
🟡 2025-02-12 18:40:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13541 13465 0 19 18 39

2025-02-12 18:42:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-12 18:59:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
114 (only retried tests) 78 0 0 4 32

🟢 2025-02-12 19:00:03 UTC Build successful.
🟢 2025-02-12 19:00:29 UTC ydbd size 3.6 GiB changed* by +9.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b9ac376 merge: c038682 diff diff %
ydbd size 3 876 050 096 Bytes 3 876 059 504 Bytes +9.2 KiB +0.000%
ydbd stripped size 1 357 316 240 Bytes 1 357 321 360 Bytes +5.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 12, 2025

2025-02-12 17:05:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for c038682 has started.
2025-02-12 17:07:16 UTC Artifacts will be uploaded here
2025-02-12 17:10:30 UTC ya make is running...
🟡 2025-02-12 18:40:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27781 25187 0 1 2458 135

2025-02-12 18:45:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-12 18:57:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 81 0 0 2 125

🟢 2025-02-12 18:57:24 UTC Build successful.
🟢 2025-02-12 18:57:44 UTC ydbd size 2.1 GiB changed* by +10.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b9ac376 merge: c038682 diff diff %
ydbd size 2 228 992 368 Bytes 2 229 003 104 Bytes +10.5 KiB +0.000%
ydbd stripped size 473 267 800 Bytes 473 274 456 Bytes +6.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 changed the title Correct Rows count in Block Output Channels (#11893) WIP Correct Rows count in Block Output Channels (#11893) DO NOT MERGE Feb 13, 2025
Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 10:21:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5263b84 has started.
2025-02-14 10:21:42 UTC Artifacts will be uploaded here
2025-02-14 10:24:50 UTC ya make is running...
🟡 2025-02-14 12:00:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28136 25536 0 12 2456 132

2025-02-14 12:03:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-14 12:33:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 84 0 1 0 127

2025-02-14 12:33:32 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-14 12:57:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 65 0 0 0 123

🟢 2025-02-14 12:57:38 UTC Build successful.
🟢 2025-02-14 12:58:01 UTC ydbd size 2.1 GiB changed* by +7.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d0a16a7 merge: 5263b84 diff diff %
ydbd size 2 233 229 208 Bytes 2 233 236 872 Bytes +7.5 KiB +0.000%
ydbd stripped size 473 950 840 Bytes 473 953 656 Bytes +2.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 10:21:50 UTC Pre-commit check linux-x86_64-release-asan for 5263b84 has started.
2025-02-14 10:22:20 UTC Artifacts will be uploaded here
2025-02-14 10:26:18 UTC ya make is running...
🟡 2025-02-14 12:09:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13927 13802 0 70 15 40

2025-02-14 12:10:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-14 12:23:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 144 0 4 3 37

2025-02-14 12:24:02 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-14 12:35:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79 (only retried tests) 38 0 4 5 32

🟢 2025-02-14 12:35:47 UTC Build successful.
🟢 2025-02-14 12:36:21 UTC ydbd size 3.6 GiB changed* by +10.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d0a16a7 merge: 5263b84 diff diff %
ydbd size 3 883 778 136 Bytes 3 883 789 304 Bytes +10.9 KiB +0.000%
ydbd stripped size 1 359 932 208 Bytes 1 359 937 968 Bytes +5.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911
Copy link
Collaborator Author

Hor911 commented Feb 25, 2025

image

TPC-H scale 10 Q1 (main version)

@Hor911
Copy link
Collaborator Author

Hor911 commented Feb 25, 2025

image

Mixed cluster: main + buggy PR, request through main (data loss)

@Hor911
Copy link
Collaborator Author

Hor911 commented Feb 25, 2025

image

Mixed cluster, main + buggy PR, request through new version (data loss + group missed completely)

@Hor911
Copy link
Collaborator Author

Hor911 commented Feb 25, 2025

image

Mixed cluster: main + fixed PR, request through main (correct result)

@Hor911
Copy link
Collaborator Author

Hor911 commented Feb 25, 2025

image

Mixed cluster, main + fixed PR, request through new version (correct result)

@Hor911 Hor911 changed the title WIP Correct Rows count in Block Output Channels (#11893) DO NOT MERGE Correct Rows count in Block Output Channels (#11893) Feb 25, 2025
@Hor911 Hor911 force-pushed the correct_stat_in_block_output_channels2 branch from 7063634 to d50e5af Compare February 25, 2025 11:50
Copy link

github-actions bot commented Feb 25, 2025

🔴 2025-02-27 08:30:43 UTC The validation of the Pull Request description has failed. Please update the description.

PR description is empty. Please fill it out.

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 11:52:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0a83e5d has started.
2025-02-25 11:52:12 UTC Artifacts will be uploaded here
2025-02-25 11:55:23 UTC ya make is running...
🟡 2025-02-25 13:28:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28257 25663 0 2 2461 131

2025-02-25 13:31:35 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 13:43:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
199 (only retried tests) 72 0 0 0 127

🟢 2025-02-25 13:43:36 UTC Build successful.
🟢 2025-02-25 13:43:56 UTC ydbd size 2.1 GiB changed* by +7.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b58a028 merge: 0a83e5d diff diff %
ydbd size 2 243 209 832 Bytes 2 243 217 496 Bytes +7.5 KiB +0.000%
ydbd stripped size 474 901 528 Bytes 474 904 344 Bytes +2.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 11:56:37 UTC Pre-commit check linux-x86_64-release-asan for 0a83e5d has started.
2025-02-25 11:56:52 UTC Artifacts will be uploaded here
2025-02-25 12:00:01 UTC ya make is running...
🟡 2025-02-25 13:29:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13881 13812 0 23 12 34

2025-02-25 13:31:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 13:43:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
107 (only retried tests) 67 0 0 10 30

🟢 2025-02-25 13:43:15 UTC Build successful.
🟢 2025-02-25 13:43:40 UTC ydbd size 3.6 GiB changed* by +10.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b58a028 merge: 0a83e5d diff diff %
ydbd size 3 900 116 896 Bytes 3 900 128 048 Bytes +10.9 KiB +0.000%
ydbd stripped size 1 365 335 376 Bytes 1 365 341 136 Bytes +5.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 changed the title Correct Rows count in Block Output Channels (#11893) Correct Rows count in Block Output Channels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant