Skip to content

schemeshard: fix enable_alter_database_create_hive_first mode #10074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Oct 3, 2024

Storage pools duplication (in memory only) happened at the first database alter (first alter is actually constructs the database) causes StatusInvalidParameter errors for the next alters if they repeat storage pools specification. Ydbcp does exactly that and so databases created via ydbcp are displayed in the webui as having CONFIGURING state instead of RUNNING.

Databases stuck in that state are actually fully functional, but still are not being able to execute some alters until root schemeshard is rebooted.

KIKIMR-10367
YDBOPS-7628

Changelog entry

Fix alter-extsubdomain behaviour that could prevent some database alters from executing when enable_alter_database_create_hive_first feature flag is enabled.

Changelog category

  • Bugfix

…eate_hive_first mode

Storage pools duplication (in memory only) happened at the first database alter
(first alter is actually constructs the database) causes StatusInvalidParameter errors
for the next alters if they repeat storage pools specifiction.
Ydbcp does exactly that and so databases created via ydbcp are displayed in the webui
as having CONFIGURING state instead of RUNNING.

Databases stuck in that state are actually fully functional, but still are not being
able to execute some alters until root schemeshard is rebooted.

KIKIMR-10367
YDBOPS-7628
@github-actions github-actions bot added the bugfix label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 19:59:02 UTC Pre-commit check linux-x86_64-release-asan for 432d12e has started.
2024-10-03 19:59:13 UTC Artifacts will be uploaded here
2024-10-03 20:02:11 UTC ya make is running...
🟡 2024-10-03 21:35:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10348 9891 0 106 313 38

🟢 2024-10-03 21:36:59 UTC Build successful.
🟢 2024-10-03 21:37:32 UTC ydbd size 5.7 GiB changed* by +1.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 595af5f merge: 432d12e diff diff %
ydbd size 6 086 289 376 Bytes 6 086 290 576 Bytes +1.2 KiB +0.000%
ydbd stripped size 1 520 590 960 Bytes 1 520 591 472 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 20:01:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 432d12e has started.
2024-10-03 20:01:52 UTC Artifacts will be uploaded here
2024-10-03 20:04:51 UTC ya make is running...
🟡 2024-10-03 20:53:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15272 13701 0 1 1467 103

2024-10-03 20:54:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-03 21:05:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 96 0 0 0 94

🟢 2024-10-03 21:05:44 UTC Build successful.
🟢 2024-10-03 21:06:04 UTC ydbd size 2.8 GiB changed* by +616 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 595af5f merge: 432d12e diff diff %
ydbd size 3 001 837 456 Bytes 3 001 838 072 Bytes +616 Bytes +0.000%
ydbd stripped size 477 361 080 Bytes 477 361 336 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon requested a review from snaury October 4, 2024 07:03
@ijon ijon merged commit 3ed2931 into ydb-platform:main Oct 4, 2024
11 checks passed
@ijon ijon deleted the fix-enable-alter-database-create-hive-first branch October 4, 2024 08:27
ijon added a commit to ijon/ydb that referenced this pull request Oct 4, 2024
…atform#10074)

Storage pools duplication (in memory only) happened at the first database alter (first alter is actually constructs the database) causes StatusInvalidParameter errors for the next alters if they repeat storage pools specification. Ydbcp does exactly that and so databases created via ydbcp are displayed in the webui as having CONFIGURING state instead of RUNNING.

Databases stuck in that state are actually fully functional, but still are not being able to execute some alters until root schemeshard is rebooted.

KIKIMR-10367
YDBOPS-7628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants