Skip to content

24-3: Add min delay before shutdown (#9688) #10087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented Oct 4, 2024

Changelog entry

Add setting to configure min delay before node shutdown

Changelog category

  • New feature

Additional information

This setting is needed to make sure that clients forget about the node after its removal from discovery

@pixcc pixcc requested a review from CyberROFL October 4, 2024 10:34
@pixcc pixcc self-assigned this Oct 4, 2024
@pixcc pixcc requested a review from a team as a code owner October 4, 2024 10:34
Copy link

github-actions bot commented Oct 4, 2024

2024-10-04 10:37:07 UTC Pre-commit check for dbd56f6 has started.
2024-10-04 10:40:28 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-04 11:17:31 UTC Build successful.

Copy link

github-actions bot commented Oct 4, 2024

2024-10-04 10:38:32 UTC Pre-commit check for dbd56f6 has started.
2024-10-04 10:41:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-04 11:44:32 UTC Build successful.
2024-10-04 11:44:50 UTC Tests are running...
🔴 2024-10-04 13:35:10 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40015 34750 0 8 5214 43

🟢 2024-10-04 13:35:58 UTC ydbd size 8.2 GiB changed* by +57.7 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 6508540 merge: dbd56f6 diff diff %
ydbd size 8 805 545 168 Bytes 8 805 604 208 Bytes +57.7 KiB +0.001%
ydbd stripped size 480 069 544 Bytes 480 078 216 Bytes +8.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 4, 2024

2024-10-04 10:38:55 UTC Pre-commit check for dbd56f6 has started.
2024-10-04 10:41:49 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-04 11:27:24 UTC Build successful.
2024-10-04 11:27:40 UTC Tests are running...
🔴 2024-10-04 13:30:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11464 11385 0 7 25 47

🟢 2024-10-04 13:30:58 UTC ydbd size 5.6 GiB changed* by +45.8 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 6508540 merge: dbd56f6 diff diff %
ydbd size 5 962 075 736 Bytes 5 962 122 592 Bytes +45.8 KiB +0.001%
ydbd stripped size 1 491 985 472 Bytes 1 491 999 904 Bytes +14.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc merged commit a2be43b into ydb-platform:stable-24-3 Oct 7, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants