Skip to content

Fix kafka produce codec to 24 3 #10270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Fix kafka produce codec to 24 3 #10270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ee3f89
Fix kafka produce codec
niksaveliev Oct 3, 2024
c031738
Fix codec enum
niksaveliev Oct 4, 2024
b68034b
Fix include
niksaveliev Oct 4, 2024
7b923ca
fix
niksaveliev Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ydb/core/kafka_proxy/actors/kafka_produce_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

#include <ydb/core/persqueue/utils.h>
#include <ydb/core/protos/grpc_pq_old.pb.h>
#include <ydb/public/api/protos/draft/persqueue_common.pb.h>

namespace NKafka {

Expand Down Expand Up @@ -262,6 +263,7 @@ THolder<TEvPartitionWriter::TEvWriteRequest> Convert(const TProduceRequestData::

for (const auto& record : batch->Records) {
NKikimrPQClient::TDataChunk proto;
proto.set_codec(NPersQueueCommon::RAW);
for(auto& h : record.Headers) {
auto res = proto.AddMessageMeta();
if (h.Key) {
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/kafka_proxy/actors/kafka_produce_actor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ using namespace NKikimrClient;
// Each request can contain data for writing to several topics, and in each topic to several partitions.
// When a request to write to an unknown topic arrives, the actor changes the state to Init until it receives
// information about all the topics needed to process the request.
//
//
// Requests are processed in parallel, but it is guaranteed that the recording order will be preserved.
// The order of responses to requests is also guaranteed.
//
Expand Down
Loading