Skip to content

fix filter handling in nodes and groups #10277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

adameat
Copy link
Member

@adameat adameat commented Oct 10, 2024

Changelog entry

fix filter handling in nodes and groups, closes ydb-platform/ydb-embedded-ui#909

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

image_2024-10-10_15-54-30

@adameat adameat added the bugfix label Oct 10, 2024
@adameat adameat requested a review from a team as a code owner October 10, 2024 09:27
@github-actions github-actions bot added bugfix and removed bugfix labels Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

2024-10-10 09:31:00 UTC Pre-commit check linux-x86_64-release-asan for b7f2831 has started.
2024-10-10 09:31:11 UTC Artifacts will be uploaded here
2024-10-10 09:34:01 UTC ya make is running...
🟡 2024-10-10 11:05:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10148 9918 0 73 52 105

🟢 2024-10-10 11:06:22 UTC Build successful.
🟢 2024-10-10 11:06:52 UTC ydbd size 5.7 GiB changed* by +3.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1738d8c merge: b7f2831 diff diff %
ydbd size 6 103 922 760 Bytes 6 103 926 776 Bytes +3.9 KiB +0.000%
ydbd stripped size 1 520 991 984 Bytes 1 520 996 016 Bytes +3.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 10, 2024

2024-10-10 09:31:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for b7f2831 has started.
2024-10-10 09:31:16 UTC Artifacts will be uploaded here
2024-10-10 09:34:17 UTC ya make is running...
🟡 2024-10-10 10:33:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14906 13415 0 5 1380 106

2024-10-10 10:34:37 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-10 10:55:26 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 8 0 0 1 100

🟢 2024-10-10 10:55:32 UTC Build successful.
🟢 2024-10-10 10:55:52 UTC ydbd size 2.8 GiB changed* by -416 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1738d8c merge: b7f2831 diff diff %
ydbd size 3 012 071 792 Bytes 3 012 071 376 Bytes -416 Bytes -0.000%
ydbd stripped size 477 602 296 Bytes 477 602 168 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Oct 10, 2024
@adameat adameat enabled auto-merge (squash) October 10, 2024 09:33
@adameat adameat merged commit e7ff88e into ydb-platform:main Oct 10, 2024
14 of 16 checks passed
@adameat adameat deleted the fix-filter-handling branch October 10, 2024 12:07
adameat added a commit to adameat/ydb that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow filter nodes with space-delimited list of node ids
2 participants