Skip to content

improve node deletion in hive (#7218) #10393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

improve node deletion in hive

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

  • Delete nodes even when hive restarts between their disconnect and the time they are allowed to be deleted. Relevant for instance group update.
  • Set default node delete period = node broker epoch

@vporyadke vporyadke requested a review from a team as a code owner October 14, 2024 11:13
Copy link

github-actions bot commented Oct 14, 2024

2024-10-14 11:16:46 UTC Pre-commit check for b8c4d0c has started.
2024-10-14 11:19:35 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-14 11:53:59 UTC Build successful.

Copy link

github-actions bot commented Oct 14, 2024

2024-10-14 11:17:40 UTC Pre-commit check for b8c4d0c has started.
2024-10-14 11:20:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-14 12:21:54 UTC Build successful.
2024-10-14 12:22:12 UTC Tests are running...
🔴 2024-10-14 14:08:46 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40043 34780 0 6 5215 42

🟢 2024-10-14 14:09:26 UTC ydbd size 8.2 GiB changed* by +13.0 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: f6729a6 merge: b8c4d0c diff diff %
ydbd size 8 809 812 312 Bytes 8 809 825 576 Bytes +13.0 KiB +0.000%
ydbd stripped size 481 749 000 Bytes 481 750 536 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 14, 2024

2024-10-14 11:19:05 UTC Pre-commit check for b8c4d0c has started.
2024-10-14 11:21:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-14 12:04:49 UTC Build successful.
2024-10-14 12:05:04 UTC Tests are running...
🔴 2024-10-14 14:06:16 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11493 11409 0 11 26 47

🟢 2024-10-14 14:07:02 UTC ydbd size 5.5 GiB changed* by +16.9 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: f6729a6 merge: b8c4d0c diff diff %
ydbd size 5 956 818 096 Bytes 5 956 835 408 Bytes +16.9 KiB +0.000%
ydbd stripped size 1 495 164 896 Bytes 1 495 167 136 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke merged commit 9903295 into ydb-platform:stable-24-3 Oct 14, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants