24-2: Views: throw a human-readable error in case of a missing WITH (security_invoker = true) (#9320) (#9783) #10403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This is not a real fix, it just masks the problem. View queries are not parsed correctly in the ParseViewQuery function. AST cannot be built in some cases. However, we didn't report AST building error as a failure previously, because we are using only the query text, not the AST. We have fixed the parsing in the other commit (see ydb-platform#9860).
|
⚪
|
|
⚪
|
fomichev3000
approved these changes
Oct 15, 2024
|
These improvements are not needed in the target branch, because the customers have already moved to a version of YDB built from a more recent branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
Backport:
WITH (security_invoker = true)#9320