Skip to content

Do not try to collect extra sort columns if ORDER BY is ignored #10417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

nepal
Copy link
Collaborator

@nepal nepal commented Oct 14, 2024

Changelog entry

  • Do not try to collect extra sort columns if ORDER BY is ignored

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@nepal nepal requested a review from a team as a code owner October 14, 2024 21:09
@nepal nepal added area/yql YQL query language issues and removed bugfix labels Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

2024-10-14 21:13:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 20d79d0 has started.
2024-10-14 21:13:19 UTC Artifacts will be uploaded here
2024-10-14 21:16:26 UTC ya make is running...
🟡 2024-10-14 22:21:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76007 62031 0 3 13868 105

2024-10-14 22:28:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-14 22:39:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 5 0 0 0 100

🟢 2024-10-14 22:40:00 UTC Build successful.
🟢 2024-10-14 22:40:17 UTC ydbd size 2.8 GiB changed* by -28.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6e67eb5 merge: 20d79d0 diff diff %
ydbd size 3 010 987 104 Bytes 3 010 957 568 Bytes -28.8 KiB -0.001%
ydbd stripped size 477 510 168 Bytes 477 508 248 Bytes -1.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 14, 2024

2024-10-14 21:13:54 UTC Pre-commit check linux-x86_64-release-asan for 20d79d0 has started.
2024-10-14 21:14:05 UTC Artifacts will be uploaded here
2024-10-14 21:17:03 UTC ya make is running...
🟡 2024-10-14 22:56:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13151 12641 0 124 339 47

🟢 2024-10-14 22:57:45 UTC Build successful.
🟢 2024-10-14 22:58:19 UTC ydbd size 5.7 GiB changed* by -47.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6e67eb5 merge: 20d79d0 diff diff %
ydbd size 6 099 992 680 Bytes 6 099 944 480 Bytes -47.1 KiB -0.001%
ydbd stripped size 1 520 943 056 Bytes 1 520 931 152 Bytes -11.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nepal nepal enabled auto-merge (squash) October 15, 2024 05:10
@nepal nepal merged commit bc2bf72 into ydb-platform:main Oct 15, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yql YQL query language issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants