Skip to content

base: move TCompactionPolicy out of flat_scheme_op.proto #10495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Oct 16, 2024

Move TCompactionPolicy from flat_scheme_op.proto to distinct .proto file.

The final goal is to break dependency of ydb/core/base/ on flat_scheme_op.pb.h.
Currently, flat_scheme_op.proto contains few fundamental structures essential for ydb/core/base/, alongside numerous higher-level components (scheme entities descriptions, scheme operations) that are irrelevant to ydb/core/base/'s needs.

This is part of "improve schemeshard operation build-time" effort (#10633).

Changelog category

  • Not for changelog

@ijon ijon force-pushed the core-isolate-compaction-policy branch from f30dbfa to 5f5ec6a Compare October 16, 2024 11:28
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 16, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 16, 2024
@ijon ijon force-pushed the core-isolate-compaction-policy branch from 5f5ec6a to e4b9c93 Compare October 16, 2024 14:21
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 16, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 16, 2024

This comment was marked as outdated.

This comment was marked as outdated.

@ijon ijon force-pushed the core-isolate-compaction-policy branch from e4b9c93 to 7f5e729 Compare October 16, 2024 14:59

This comment was marked as outdated.

This comment was marked as outdated.

@ijon ijon force-pushed the core-isolate-compaction-policy branch from 7f5e729 to 6df8fa9 Compare October 16, 2024 19:29
Copy link

github-actions bot commented Oct 16, 2024

2024-10-16 19:33:33 UTC Pre-commit check linux-x86_64-release-asan for b0aae10 has started.
2024-10-16 19:33:44 UTC Artifacts will be uploaded here
2024-10-16 19:37:11 UTC ya make is running...
🟡 2024-10-16 21:30:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12019 11741 0 85 93 100

🟢 2024-10-16 21:31:10 UTC Build successful.
🟢 2024-10-16 21:31:45 UTC ydbd size 5.7 GiB changed* by -816 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 09bef8a merge: b0aae10 diff diff %
ydbd size 6 129 681 016 Bytes 6 129 680 200 Bytes -816 Bytes -0.000%
ydbd stripped size 1 529 354 544 Bytes 1 529 355 472 Bytes +928 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 16, 2024

2024-10-16 19:33:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for b0aae10 has started.
2024-10-16 19:33:45 UTC Artifacts will be uploaded here
2024-10-16 19:37:04 UTC ya make is running...
🟡 2024-10-16 21:03:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41774 36171 0 7 5492 104

2024-10-16 21:07:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-16 21:18:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
119 (only retried tests) 21 0 0 1 97

🟢 2024-10-16 21:18:38 UTC Build successful.
🟢 2024-10-16 21:18:56 UTC ydbd size 2.8 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 09bef8a merge: b0aae10 diff diff %
ydbd size 3 028 485 792 Bytes 3 028 489 000 Bytes +3.1 KiB +0.000%
ydbd stripped size 480 129 496 Bytes 480 133 752 Bytes +4.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon requested review from snaury and CyberROFL October 17, 2024 09:02
@ijon ijon merged commit e051e10 into ydb-platform:main Oct 17, 2024
10 checks passed
@ijon ijon deleted the core-isolate-compaction-policy branch October 17, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants