Skip to content

24-3: ImportData: consistent limits #10526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

24-3: ImportData: consistent limits #10526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ydb/public/api/protos/ydb_import.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ message ImportDataRequest {
// - sorted by primary key;
// - all keys must be from the same partition;
// - table has no global secondary indexes;
// - size of serialized data is limited to 8 MB.
bytes data = 3 [(length).le = 8388608];
// - size of serialized data is limited to 16 MB.
bytes data = 3 [(length).le = 16777216];
oneof format {
// Result of `ydb tools dump`
YdbDumpFormat ydb_dump = 4;
Expand Down
4 changes: 2 additions & 2 deletions ydb/public/lib/ydb_cli/dump/dump.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ struct TRestoreSettings: public TOperationRequestSettings<TRestoreSettings> {
ImportData,
};

static constexpr ui64 MaxBytesPerRequest = 8_MB;
static constexpr ui64 MaxBytesPerRequest = 16_MB;

FLUENT_SETTING_DEFAULT(EMode, Mode, EMode::Yql);
FLUENT_SETTING_DEFAULT(bool, DryRun, false);
Expand All @@ -67,7 +67,7 @@ struct TRestoreSettings: public TOperationRequestSettings<TRestoreSettings> {
FLUENT_SETTING_DEFAULT(bool, SkipDocumentTables, false);
FLUENT_SETTING_DEFAULT(bool, SavePartialResult, false);

FLUENT_SETTING_DEFAULT(ui64, MemLimit, 16_MB);
FLUENT_SETTING_DEFAULT(ui64, MemLimit, 32_MB);
FLUENT_SETTING_DEFAULT(ui64, RowsPerRequest, 0);
FLUENT_SETTING_DEFAULT(ui64, BytesPerRequest, 512_KB);
FLUENT_SETTING_DEFAULT(ui64, RequestUnitsPerRequest, 30);
Expand Down
Loading