Skip to content

fix import to arcadia #10590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Oct 18, 2024

Fix a linking error that has been caught during the YDB Import 620. More specifically:

  • add missing peerdir to ya.make
  • remove templates, because their instantiation was missing and they are not needed and only complicate things

This comment was marked as outdated.

This comment was marked as outdated.

@jepett0 jepett0 marked this pull request as ready for review October 18, 2024 08:59

This comment was marked as outdated.

This comment was marked as outdated.

@jepett0 jepett0 force-pushed the IndexBackupRestore.implicit_min_partitions_count.2.fixup.1 branch from c64d10c to c24187c Compare October 18, 2024 12:55

This comment was marked as outdated.

This comment was marked as outdated.

@jepett0 jepett0 force-pushed the IndexBackupRestore.implicit_min_partitions_count.2.fixup.1 branch from c24187c to 60008a5 Compare October 18, 2024 14:29
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 14:33:49 UTC Pre-commit check linux-x86_64-release-asan for ffc5a97 has started.
2024-10-18 14:34:00 UTC Artifacts will be uploaded here
2024-10-18 14:37:03 UTC ya make is running...
🟡 2024-10-18 16:10:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12292 12060 0 66 64 102

🟢 2024-10-18 16:11:14 UTC Build successful.
🟢 2024-10-18 16:11:47 UTC ydbd size 5.7 GiB changed* by +1.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: eb88635 merge: ffc5a97 diff diff %
ydbd size 6 103 710 472 Bytes 6 103 711 520 Bytes +1.0 KiB +0.000%
ydbd stripped size 1 521 729 136 Bytes 1 521 729 840 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 14:34:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for ffc5a97 has started.
2024-10-18 14:34:41 UTC Artifacts will be uploaded here
2024-10-18 14:37:45 UTC ya make is running...
🟡 2024-10-18 15:48:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75215 61189 0 19 13908 99

2024-10-18 15:55:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-18 16:07:13 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
131 (only retried tests) 41 0 0 0 90

🟢 2024-10-18 16:07:20 UTC Build successful.
🟢 2024-10-18 16:07:41 UTC ydbd size 2.8 GiB changed* by -24 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: eb88635 merge: ffc5a97 diff diff %
ydbd size 3 012 692 184 Bytes 3 012 692 160 Bytes -24 Bytes -0.000%
ydbd stripped size 477 690 008 Bytes 477 690 008 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 requested review from MBkkt and CyberROFL October 18, 2024 14:38
@jepett0 jepett0 enabled auto-merge (squash) October 18, 2024 15:09
@jepett0 jepett0 merged commit f5d549e into ydb-platform:main Oct 18, 2024
10 checks passed
jepett0 added a commit to jepett0/ydb that referenced this pull request Oct 18, 2024
jepett0 added a commit to jepett0/ydb that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants