Skip to content

build_bloat: add paths sorting to improve visual stability #10604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Oct 18, 2024

Sorting paths enables the renderer to produce more consistent visual results across different runs, even when build statistics change. Elements with minimal duration change between runs are more likely to maintain their positions on a grid.

This stability makes it easier to visually compare the outcomes of build time optimization efforts aimed at specific modules or components.

Without sorting:

From To
image image

With sorting:

From To
image image

This is part of "improve schemeshard operation build-time" effort (#10633).

Changelog category

  • Not for changelog

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 12:14:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for d163e48 has started.
2024-10-18 12:15:02 UTC Artifacts will be uploaded here
2024-10-18 12:17:26 UTC ya make is running...
🟢 2024-10-18 12:17:31 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-10-18 12:17:36 UTC Build successful.

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 12:17:41 UTC Pre-commit check linux-x86_64-release-asan for d163e48 has started.
2024-10-18 12:17:52 UTC Artifacts will be uploaded here
2024-10-18 12:20:18 UTC ya make is running...
🟢 2024-10-18 12:20:23 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-10-18 12:20:28 UTC Build successful.

@ijon ijon merged commit 39e82bd into ydb-platform:main Oct 18, 2024
12 checks passed
@ijon ijon deleted the build_bloat-improve-visual-stability branch October 18, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants