Skip to content

Legacy kv api remove #10614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2024
Merged

Legacy kv api remove #10614

merged 4 commits into from
Oct 24, 2024

Conversation

mregrock
Copy link
Collaborator

Changelog entry

Remove legacy KV API and LocalEnumerateTablets

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

⚪ 2024-10-18 13:40:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4996f02 has started.
⚪ 2024-10-18 13:41:08 UTC Artifacts will be uploaded here
⚪ 2024-10-18 13:44:33 UTC ya make is running...
🟡 2024-10-18 15:12:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41808 36205 0 6 5503 94

⚪ 2024-10-18 15:16:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-18 15:27:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 11 0 0 0 90

🟢 2024-10-18 15:27:50 UTC Build successful.
🟢 2024-10-18 15:28:08 UTC ydbd size 2.8 GiB changed* by -1.3 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: eb88635 merge: 4996f02 diff diff %
ydbd size 3 012 692 184 Bytes 3 011 329 296 Bytes -1.3 MiB -0.045%
ydbd stripped size 477 690 008 Bytes 477 513 816 Bytes -172.1 KiB -0.037%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

⚪ 2024-10-18 13:42:10 UTC Pre-commit check linux-x86_64-release-asan for 4996f02 has started.
⚪ 2024-10-18 13:42:22 UTC Artifacts will be uploaded here
⚪ 2024-10-18 13:45:47 UTC ya make is running...
🟡 2024-10-18 15:41:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12037 11643 0 85 274 35

🟢 2024-10-18 15:42:21 UTC Build successful.
🟢 2024-10-18 15:42:54 UTC ydbd size 5.7 GiB changed* by -2.6 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: eb88635 merge: 4996f02 diff diff %
ydbd size 6 103 710 472 Bytes 6 100 935 200 Bytes -2.6 MiB -0.045%
ydbd stripped size 1 521 729 136 Bytes 1 521 148 016 Bytes -567.5 KiB -0.038%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

kruall
kruall requested changes Oct 24, 2024
View reviewed changes
ydb/core/driver_lib/cli_utils/cli_cmds_admin.cpp Outdated
@@ -7,7 +7,6 @@ namespace NDriverClient {
TClientCommandAdmin::TClientCommandAdmin()
: TClientCommandTree("admin", {}, "YDB management and administration")
{
AddCommand(std::make_unique<TClientCommandTablet>());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А там только команды для кв таблетки были?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется там еще есть команды drain и fill, не стоит удалять

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 17:54:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4649396 has started.
⚪ 2024-10-24 17:54:31 UTC Artifacts will be uploaded here
⚪ 2024-10-24 17:57:48 UTC ya make is running...
🟡 2024-10-24 18:52:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41715 36116 0 1 5503 95

⚪ 2024-10-24 18:56:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-24 19:07:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 4 0 0 1 91

🟢 2024-10-24 19:07:34 UTC Build successful.
🟢 2024-10-24 19:07:50 UTC ydbd size 2.8 GiB changed* by -1.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6d94c69 merge: 4649396 diff diff %
ydbd size 3 032 440 840 Bytes 3 031 330 536 Bytes -1.1 MiB -0.037%
ydbd stripped size 480 963 128 Bytes 480 813 624 Bytes -146.0 KiB -0.031%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

⚪ 2024-10-24 11:53:45 UTC Pre-commit check linux-x86_64-release-asan for 4649396 has started.
⚪ 2024-10-24 11:54:19 UTC Artifacts will be uploaded here
⚪ 2024-10-24 11:58:09 UTC ya make is running...
🟡 2024-10-24 13:41:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11851 11636 0 67 47 101

🟢 2024-10-24 13:42:20 UTC Build successful.
🟢 2024-10-24 13:42:54 UTC ydbd size 5.7 GiB changed* by -2.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6d94c69 merge: 4649396 diff diff %
ydbd size 6 135 181 936 Bytes 6 132 930 376 Bytes -2.1 MiB -0.037%
ydbd stripped size 1 531 700 304 Bytes 1 531 194 320 Bytes -494.1 KiB -0.033%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mregrock mregrock merged commit ebd64a3 into ydb-platform:main Oct 24, 2024
10 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 28, 2024
Merged
@shnikd shnikd mentioned this pull request Nov 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 8, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 13, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 14, 2024
Merged
mregrock added a commit to mregrock/ydb that referenced this pull request Feb 25, 2025
@mregrock
Legacy kv api remove (ydb-platform#10614)
ebcb6f8 
Remove legacy KV API and LocalEnumerateTablets
mregrock added a commit to mregrock/ydb that referenced this pull request Mar 5, 2025
@mregrock
Legacy kv api remove (ydb-platform#10614)
9755a5e 
Remove legacy KV API and LocalEnumerateTablets
mregrock added a commit that referenced this pull request Mar 6, 2025
@mregrock
Remove legacy kv api (#10614) (#15004)
c2244f7
@serbel324 serbel324 mentioned this pull request Mar 10, 2025
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 11, 2025
Merged
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@mregrock @blinkov
Remove legacy kv api (#10614) (#15004)
0d36836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruall kruall kruall approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mregrock @kruall