Skip to content

Implement runtime flags codegen in C++ #10711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

snaury
Copy link
Member

@snaury snaury commented Oct 22, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Python binaries with complex dependencies cannot be used in cmake export codegen. Reimplement codegen in C++.

See #9748.

@snaury snaury self-assigned this Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 11:43:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8ca4a23 has started.
2024-10-22 11:43:43 UTC Artifacts will be uploaded here
2024-10-22 11:47:22 UTC Check cancelled

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 11:45:18 UTC Pre-commit check linux-x86_64-release-asan for 8ca4a23 has started.
2024-10-22 11:47:21 UTC Check cancelled

@snaury snaury force-pushed the runtime-feature-flags-gen-cpp branch from 8b433ff to 33706a6 Compare October 22, 2024 11:47
@snaury snaury marked this pull request as ready for review October 22, 2024 11:47
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 11:48:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1437f53 has started.
2024-10-22 11:48:07 UTC Artifacts will be uploaded here
2024-10-22 11:51:40 UTC ya make is running...
🟡 2024-10-22 13:15:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41505 35905 0 1 5502 97

2024-10-22 13:19:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-22 13:30:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 4 0 0 0 93

🟢 2024-10-22 13:30:56 UTC Build successful.
🟢 2024-10-22 13:31:15 UTC ydbd size 2.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f7709b6 merge: 1437f53 diff diff %
ydbd size 3 012 001 568 Bytes 3 012 001 568 Bytes 0 Bytes 0.000%
ydbd stripped size 478 074 552 Bytes 478 074 552 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 11:51:23 UTC Pre-commit check linux-x86_64-release-asan for 1437f53 has started.
2024-10-22 11:51:34 UTC Artifacts will be uploaded here
2024-10-22 11:54:53 UTC ya make is running...
🟡 2024-10-22 13:33:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11660 11479 0 41 40 100

🟢 2024-10-22 13:34:40 UTC Build successful.
🟢 2024-10-22 13:35:11 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f7709b6 merge: 1437f53 diff diff %
ydbd size 6 099 054 144 Bytes 6 099 054 048 Bytes -96 Bytes -0.000%
ydbd stripped size 1 522 369 648 Bytes 1 522 369 584 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury enabled auto-merge (squash) October 22, 2024 12:22
@snaury snaury merged commit 799414a into ydb-platform:main Oct 22, 2024
10 checks passed
@snaury snaury deleted the runtime-feature-flags-gen-cpp branch October 22, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants