Skip to content

Improve Shared Cache S3FIFO #10825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

kunga
Copy link
Member

@kunga kunga commented Oct 24, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

  • Limit reinserts as it was suggested in a comment and is done in Otter
  • Fix limiting the small queue when there is not enough items in the main queue
  • Simplify ghost queue by using hash table

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 09:49:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for bffce11 has started.
2024-10-24 09:49:15 UTC Artifacts will be uploaded here
2024-10-24 09:52:18 UTC ya make is running...
2024-10-24 09:59:45 UTC Check cancelled

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 09:50:13 UTC Pre-commit check linux-x86_64-release-asan for bffce11 has started.
2024-10-24 09:50:24 UTC Artifacts will be uploaded here
2024-10-24 09:53:25 UTC ya make is running...
2024-10-24 09:59:55 UTC Check cancelled

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 10:02:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for f42368c has started.
2024-10-24 10:02:57 UTC Artifacts will be uploaded here
2024-10-24 10:05:59 UTC ya make is running...
🟡 2024-10-24 10:52:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15498 14011 0 1 1390 96

2024-10-24 10:53:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-24 11:05:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 5 0 0 0 91

🟢 2024-10-24 11:05:12 UTC Build successful.
🟢 2024-10-24 11:05:31 UTC ydbd size 2.8 GiB changed* by -67.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 71df826 merge: f42368c diff diff %
ydbd size 3 032 423 816 Bytes 3 032 354 960 Bytes -67.2 KiB -0.002%
ydbd stripped size 480 962 296 Bytes 480 954 808 Bytes -7.3 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 10:02:50 UTC Pre-commit check linux-x86_64-release-asan for f42368c has started.
2024-10-24 10:03:01 UTC Artifacts will be uploaded here
2024-10-24 10:05:59 UTC ya make is running...
🟡 2024-10-24 11:20:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10495 10120 0 54 285 36

🟢 2024-10-24 11:20:55 UTC Build successful.
🟢 2024-10-24 11:21:40 UTC ydbd size 5.7 GiB changed* by -80.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 71df826 merge: f42368c diff diff %
ydbd size 6 135 137 624 Bytes 6 135 055 224 Bytes -80.5 KiB -0.001%
ydbd stripped size 1 531 697 488 Bytes 1 531 678 352 Bytes -18.7 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga self-assigned this Oct 25, 2024
@kunga kunga marked this pull request as ready for review October 25, 2024 08:04
@kunga kunga requested a review from snaury October 25, 2024 08:17
@kunga kunga merged commit 0227c59 into ydb-platform:main Oct 25, 2024
11 checks passed
kunga added a commit to kunga/ydb that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants