Skip to content

BTreeIndex Charge Keys #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jan 23, 2024
Merged

Conversation

kunga
Copy link
Member

@kunga kunga commented Jan 17, 2024

No description provided.

Copy link

github-actions bot commented Jan 17, 2024

2024-01-22 17:03:44 UTC Pre-commit check for 92564e8 has started.
2024-01-22 17:03:47 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-22 17:05:31 UTC Build successful.
2024-01-22 17:05:42 UTC Tests are running...
🔴 2024-01-22 18:14:52 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59892 50650 0 1 9228 13

Copy link

github-actions bot commented Jan 17, 2024

2024-01-22 17:02:33 UTC Pre-commit check for 92564e8 has started.
2024-01-22 17:02:36 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-22 17:04:38 UTC Build successful.
2024-01-22 17:04:46 UTC Tests are running...
🔴 2024-01-22 18:36:24 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15890 15810 0 18 48 14

@kunga kunga added area/datashard Issues related to datashard tablets (relational table partitions) and removed area/datashard Issues related to datashard tablets (relational table partitions) labels Jan 18, 2024
using TChild = TBtreeIndexNode::TChild;

// TODO: store PageId only instead of TChild?
struct TNodeState : TBtreeIndexNode, TChild {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так нормально, или лучше TBtreeIndexNode и TChild полями сделать?

@kunga kunga marked this pull request as ready for review January 19, 2024 12:31
TRowId firstRow = pos->Slice.BeginRowId();
// Precharge the first row on the next slice
CreateCharge(env, *pos->Part, tags, includeHistory)->Do(firstRow, firstRow, keyDefaults, items, bytes);
ready &= CreateCharge(env, *pos->Part, tags, includeHistory)->Do(firstRow, firstRow, keyDefaults, items, bytes);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не понимаю как оно раньше работало..

@kunga kunga marked this pull request as draft January 19, 2024 13:56
@kunga kunga force-pushed the KIKIMR-19522-btree-precharge-keys branch from bbe3d5b to 56cf358 Compare January 19, 2024 18:07
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants