Skip to content

Don't use random scan cookie for build index #11256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

MBkkt
Copy link
Contributor

@MBkkt MBkkt commented Nov 5, 2024

We shouldn't use random cookie for build index scans. Because in such case it's possible that this random id will intersects with real transaction id. So we use invalid zero id. It's allowed because build index scans don't need some external finalize. New build index scan remove old scan from manager because it has newer version

… case it's possible that this random id will intersects with real transaction id. So we use invalid zero id. It's allowed because build index scans don't need some external finalize. New build index scan remove old scan from manager because hait has newer version
@MBkkt MBkkt requested review from snaury and CyberROFL November 5, 2024 08:51
Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 08:56:22 UTC Pre-commit check linux-x86_64-release-asan for 6d7c5cd has started.
2024-11-05 08:56:33 UTC Artifacts will be uploaded here
2024-11-05 08:59:31 UTC ya make is running...
🟡 2024-11-05 10:07:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9242 9174 0 26 9 33

🟢 2024-11-05 10:08:39 UTC Build successful.
🟢 2024-11-05 10:09:19 UTC ydbd size 5.7 GiB changed* by -1.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7672737 merge: 6d7c5cd diff diff %
ydbd size 6 150 333 736 Bytes 6 150 332 328 Bytes -1.4 KiB -0.000%
ydbd stripped size 1 535 125 648 Bytes 1 535 125 328 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 08:56:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6d7c5cd has started.
2024-11-05 08:56:57 UTC Artifacts will be uploaded here
2024-11-05 09:00:04 UTC ya make is running...
🟡 2024-11-05 09:48:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15313 13806 0 2 1404 101

2024-11-05 09:49:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-05 10:01:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 6 0 0 0 95

🟢 2024-11-05 10:01:44 UTC Build successful.
🟢 2024-11-05 10:02:05 UTC ydbd size 2.8 GiB changed* by -768 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7672737 merge: 6d7c5cd diff diff %
ydbd size 3 039 362 384 Bytes 3 039 361 616 Bytes -768 Bytes -0.000%
ydbd stripped size 481 619 384 Bytes 481 619 192 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@MBkkt MBkkt self-assigned this Nov 5, 2024
@MBkkt MBkkt merged commit 8cd1aa6 into ydb-platform:main Nov 5, 2024
11 of 12 checks passed
@MBkkt MBkkt mentioned this pull request Jan 16, 2025
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants