Skip to content

auditlog: fix logging for unsuccessful ldap logins #11438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Nov 9, 2024

Move audit logging of login operations from schemeshard to grpc service auth (AuthService).
Update web-login service login to utilize AuthService.Login.
Establish AuthService as the sole gateway and audit point for all login operations.

Dependencies:

Changelog entry

Fix audit log not recording unsuccessful ldap logins.

Changelog category

  • Bugfix

@github-actions github-actions bot added the bugfix label Nov 9, 2024

This comment was marked as outdated.

This comment was marked as outdated.

@github-actions github-actions bot added bugfix and removed bugfix labels Nov 9, 2024
@ijon ijon marked this pull request as ready for review November 10, 2024 13:17
@ijon ijon requested review from molotkov-and and adameat November 11, 2024 09:01
Copy link

github-actions bot commented Nov 11, 2024

2024-11-11 14:34:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 208e82b has started.
2024-11-11 14:34:54 UTC Artifacts will be uploaded here
2024-11-11 14:38:30 UTC ya make is running...
🟡 2024-11-11 15:27:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15359 13835 0 13 1405 106

2024-11-11 15:28:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-11 15:40:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 11 0 0 0 102

🟢 2024-11-11 15:40:29 UTC Build successful.
🟡 2024-11-11 15:40:48 UTC ydbd size 2.8 GiB changed* by +168.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6c7ed0d merge: 208e82b diff diff %
ydbd size 3 047 078 704 Bytes 3 047 250 912 Bytes +168.2 KiB +0.006%
ydbd stripped size 482 254 008 Bytes 482 267 320 Bytes +13.0 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 11, 2024

2024-11-11 14:34:59 UTC Pre-commit check linux-x86_64-release-asan for 208e82b has started.
2024-11-11 14:35:09 UTC Artifacts will be uploaded here
2024-11-11 14:38:09 UTC ya make is running...
🟡 2024-11-11 15:43:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8978 8895 0 35 9 39

🟢 2024-11-11 15:44:29 UTC Build successful.
🟡 2024-11-11 15:44:59 UTC ydbd size 5.7 GiB changed* by +275.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e31118f merge: 208e82b diff diff %
ydbd size 6 166 282 472 Bytes 6 166 564 160 Bytes +275.1 KiB +0.005%
ydbd stripped size 1 537 605 392 Bytes 1 537 659 856 Bytes +53.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon merged commit 790417d into ydb-platform:main Nov 11, 2024
10 checks passed
@ijon ijon deleted the auditlog-fix-ldap-failed-login branch November 11, 2024 15:59
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 12, 2024
ijon added a commit that referenced this pull request Nov 13, 2024
merge af4bb4b(#7060), f73f6dc(#11403), 3d0d6db(#11404), 790417d(#11438) from `main`.

Co-authored-by: Andrey Molotkov <[email protected]>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 13, 2024
…m#11492)

merge af4bb4b(ydb-platform#7060), f73f6dc(ydb-platform#11403), 3d0d6db(ydb-platform#11404), 790417d(ydb-platform#11438) from `main`.

Co-authored-by: Andrey Molotkov <[email protected]>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 20, 2024
…m#11492)

merge af4bb4b(ydb-platform#7060), f73f6dc(ydb-platform#11403), 3d0d6db(ydb-platform#11404), 790417d(ydb-platform#11438) from `main`.

Co-authored-by: Andrey Molotkov <[email protected]>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 30, 2024
…m#11492)

merge af4bb4b(ydb-platform#7060), f73f6dc(ydb-platform#11403), 3d0d6db(ydb-platform#11404), 790417d(ydb-platform#11438) from `main`.

Co-authored-by: Andrey Molotkov <[email protected]>

Move audit logging of login operations from schemeshard to grpc service auth (`AuthService`).
Update web-login service login to utilize `AuthService.Login`.
Establish `AuthService` as the sole gateway and audit point for all login operations.

### Changelog entry

Fix audit log not recording unsuccessful ldap logins.

### Changelog category

* Bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants