Skip to content

[Not for merge] Fix order of bucket processing in wide combine spilling #11471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vladl2802
Copy link
Collaborator

Changelog entry

Not for merge.

Make so wide combine on extracting data extract first from InMemory buckets and only after that extra

Changelog category

  • Improvement

Additional information

#11416

Copy link

github-actions bot commented Nov 11, 2024

2024-11-11 11:31:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0f6193b has started.
2024-11-11 11:34:27 UTC Artifacts will be uploaded here
2024-11-11 11:38:02 UTC ya make is running...
🟡 2024-11-11 12:38:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76144 62035 0 12 13993 104

2024-11-11 12:45:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-11 12:56:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
112 (only retried tests) 13 0 1 1 97

2024-11-11 12:57:01 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-11-11 13:08:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 2 0 0 0 96

🟢 2024-11-11 13:08:23 UTC Build successful.
🟢 2024-11-11 13:08:46 UTC ydbd size 2.8 GiB changed* by +96.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8c8ed07 merge: 0f6193b diff diff %
ydbd size 3 046 966 392 Bytes 3 047 065 008 Bytes +96.3 KiB +0.003%
ydbd stripped size 482 241 624 Bytes 482 264 536 Bytes +22.4 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 11, 2024

2024-11-11 11:34:57 UTC Pre-commit check linux-x86_64-release-asan for 0f6193b has started.
2024-11-11 11:36:09 UTC Artifacts will be uploaded here
2024-11-11 11:39:46 UTC ya make is running...
🟡 2024-11-11 12:47:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11463 11372 0 39 19 33

🟢 2024-11-11 12:48:28 UTC Build successful.
🟡 2024-11-11 12:48:58 UTC ydbd size 5.7 GiB changed* by +151.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8c8ed07 merge: 0f6193b diff diff %
ydbd size 6 165 970 720 Bytes 6 166 125 960 Bytes +151.6 KiB +0.003%
ydbd stripped size 1 537 561 616 Bytes 1 537 600 592 Bytes +38.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 13:25:33 UTC Pre-commit check linux-x86_64-release-asan for 4e09bb9 has started.
2024-11-12 13:25:43 UTC Artifacts will be uploaded here
2024-11-12 13:28:46 UTC ya make is running...
🟡 2024-11-12 14:43:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11498 11388 0 34 26 50

🟢 2024-11-12 14:44:19 UTC Build successful.
🟡 2024-11-12 14:44:48 UTC ydbd size 5.7 GiB changed* by +152.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f1765fb merge: 4e09bb9 diff diff %
ydbd size 6 172 404 848 Bytes 6 172 560 592 Bytes +152.1 KiB +0.003%
ydbd stripped size 1 538 432 368 Bytes 1 538 471 600 Bytes +38.3 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 13:25:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4e09bb9 has started.
2024-11-12 13:25:48 UTC Artifacts will be uploaded here
2024-11-12 13:28:49 UTC ya make is running...
🟡 2024-11-12 14:30:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76178 62021 0 14 14029 114

2024-11-12 14:38:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-12 14:49:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
156 (only retried tests) 47 0 0 1 108

🟢 2024-11-12 14:49:34 UTC Build successful.
🟢 2024-11-12 14:49:53 UTC ydbd size 2.8 GiB changed* by +92.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f1765fb merge: 4e09bb9 diff diff %
ydbd size 3 050 013 944 Bytes 3 050 108 536 Bytes +92.4 KiB +0.003%
ydbd stripped size 482 458 808 Bytes 482 477 624 Bytes +18.4 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🔴 Unable to merge your PR into the base branch. Please rebase or merge it with the base branch.

@vladl2802 vladl2802 force-pushed the improve-spilling-wide-combine-2 branch 2 times, most recently from ee0ebe9 to d95780d Compare November 14, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tpch10000 q18. WideCombiner single bucket don't fit into memory
1 participant