Skip to content

Refactor Shared Cache configuration #11567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 18, 2024
Merged

Refactor Shared Cache configuration #11567

merged 8 commits into from
Nov 18, 2024

Conversation

kunga
Copy link
Member

@kunga kunga commented Nov 13, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Get rid of additional setting class and configurator

@kunga kunga self-assigned this Nov 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:35:07 UTC Pre-commit check linux-x86_64-release-asan for 34a62ad has started.
⚪ 2024-11-13 13:35:19 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:38:26 UTC ya make is running...
🔴 2024-11-13 13:44:13 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:35:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 34a62ad has started.
⚪ 2024-11-13 13:35:21 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:38:19 UTC ya make is running...
🔴 2024-11-13 13:42:07 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 14:31:34 UTC Pre-commit check linux-x86_64-release-asan for 1186ed1 has started.
⚪ 2024-11-13 14:31:45 UTC Artifacts will be uploaded here
⚪ 2024-11-13 14:34:49 UTC ya make is running...
🔴 2024-11-13 14:39:52 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 14:31:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1186ed1 has started.
⚪ 2024-11-13 14:32:01 UTC Artifacts will be uploaded here
⚪ 2024-11-13 14:35:13 UTC ya make is running...
🔴 2024-11-13 14:43:13 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 15:30:49 UTC Pre-commit check linux-x86_64-release-asan for 3f265b8 has started.
⚪ 2024-11-13 15:30:53 UTC Artifacts will be uploaded here
⚪ 2024-11-13 15:33:51 UTC ya make is running...
🔴 2024-11-13 15:44:54 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 15:30:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3f265b8 has started.
⚪ 2024-11-13 15:31:40 UTC Artifacts will be uploaded here
⚪ 2024-11-13 15:35:26 UTC ya make is running...
🔴 2024-11-13 15:42:41 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

⚪ 2024-11-14 11:20:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for d42ba89 has started.
⚪ 2024-11-14 11:20:27 UTC Artifacts will be uploaded here
⚪ 2024-11-14 11:23:26 UTC ya make is running...
🔴 2024-11-14 11:32:39 UTC Build failed, see the logs. Also see fail summary
🟢 2024-11-14 11:32:57 UTC ydbd size 2.8 GiB changed* by -169.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2ff8722 merge: d42ba89 diff diff %
ydbd size 3 049 878 192 Bytes 3 049 705 072 Bytes -169.1 KiB -0.006%
ydbd stripped size 482 454 016 Bytes 482 433 600 Bytes -19.9 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

⚪ 2024-11-14 11:20:46 UTC Pre-commit check linux-x86_64-release-asan for d42ba89 has started.
⚪ 2024-11-14 11:20:57 UTC Artifacts will be uploaded here
⚪ 2024-11-14 11:24:04 UTC ya make is running...
🔴 2024-11-14 11:42:08 UTC Build failed, see the logs. Also see fail summary
🟢 2024-11-14 11:42:41 UTC ydbd size 5.7 GiB changed* by -360.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2ff8722 merge: d42ba89 diff diff %
ydbd size 6 171 877 816 Bytes 6 171 508 984 Bytes -360.2 KiB -0.006%
ydbd stripped size 1 538 268 624 Bytes 1 538 186 864 Bytes -79.8 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

⚪ 2024-11-14 15:51:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9b41297 has started.
⚪ 2024-11-14 15:52:05 UTC Artifacts will be uploaded here
⚪ 2024-11-14 15:55:15 UTC ya make is running...
🔴 2024-11-14 16:13:50 UTC Build failed, see the logs. Also see fail summary
🟢 2024-11-14 16:14:11 UTC ydbd size 2.8 GiB changed* by -165.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f282430 merge: 9b41297 diff diff %
ydbd size 3 052 992 072 Bytes 3 052 823 024 Bytes -165.1 KiB -0.006%
ydbd stripped size 483 022 688 Bytes 483 002 976 Bytes -19.2 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

⚪ 2024-11-14 15:52:11 UTC Pre-commit check linux-x86_64-release-asan for 9b41297 has started.
⚪ 2024-11-14 15:53:23 UTC Artifacts will be uploaded here
⚪ 2024-11-14 15:56:52 UTC ya make is running...
🔴 2024-11-14 16:10:19 UTC Build failed, see the logs. Also see fail summary
🟢 2024-11-14 16:10:50 UTC ydbd size 5.8 GiB changed* by -359.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d3eebb6 merge: 9b41297 diff diff %
ydbd size 6 179 299 856 Bytes 6 178 931 592 Bytes -359.6 KiB -0.006%
ydbd stripped size 1 540 780 816 Bytes 1 540 699 600 Bytes -79.3 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

⚪ 2024-11-15 08:22:40 UTC Pre-commit check linux-x86_64-release-asan for f723209 has started.
⚪ 2024-11-15 08:23:06 UTC Artifacts will be uploaded here
⚪ 2024-11-15 08:26:30 UTC ya make is running...
🔴 2024-11-15 08:35:37 UTC Build failed, see the logs. Also see fail summary
🟢 2024-11-15 08:35:53 UTC ydbd size 4.9 GiB changed* by -346.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0a30799 merge: f723209 diff diff %
ydbd size 5 255 177 312 Bytes 5 254 823 056 Bytes -346.0 KiB -0.007%
ydbd stripped size 1 350 163 920 Bytes 1 350 090 064 Bytes -72.1 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

⚪ 2024-11-15 08:23:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for f723209 has started.
⚪ 2024-11-15 08:23:28 UTC Artifacts will be uploaded here
⚪ 2024-11-15 08:26:29 UTC ya make is running...
🔴 2024-11-15 08:41:53 UTC Build failed, see the logs. Also see fail summary
🟢 2024-11-15 08:42:12 UTC ydbd size 2.5 GiB changed* by -184.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0a30799 merge: f723209 diff diff %
ydbd size 2 681 687 976 Bytes 2 681 499 472 Bytes -184.1 KiB -0.007%
ydbd stripped size 480 769 008 Bytes 480 744 816 Bytes -23.6 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

⚪ 2024-11-15 11:29:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for d2bdf2d has started.
⚪ 2024-11-15 11:30:32 UTC Artifacts will be uploaded here
⚪ 2024-11-15 11:34:15 UTC ya make is running...
🟡 2024-11-15 12:35:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16644 15120 0 4 1405 115

⚪ 2024-11-15 12:36:58 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-15 12:48:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
117 (only retried tests) 10 0 0 0 107

🟢 2024-11-15 12:48:56 UTC Build successful.
🟢 2024-11-15 12:49:15 UTC ydbd size 2.5 GiB changed* by -184.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 087c886 merge: d2bdf2d diff diff %
ydbd size 2 681 700 160 Bytes 2 681 511 656 Bytes -184.1 KiB -0.007%
ydbd stripped size 480 770 992 Bytes 480 746 736 Bytes -23.7 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

⚪ 2024-11-15 11:30:54 UTC Pre-commit check linux-x86_64-release-asan for d2bdf2d has started.
⚪ 2024-11-15 11:31:05 UTC Artifacts will be uploaded here
⚪ 2024-11-15 11:34:18 UTC ya make is running...
🟡 2024-11-15 12:51:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10234 10169 0 14 5 46

🟢 2024-11-15 12:52:43 UTC Build successful.
🟢 2024-11-15 12:53:11 UTC ydbd size 4.9 GiB changed* by -346.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 87530be merge: d2bdf2d diff diff %
ydbd size 5 255 200 648 Bytes 5 254 846 344 Bytes -346.0 KiB -0.007%
ydbd stripped size 1 350 173 232 Bytes 1 350 099 312 Bytes -72.2 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga mentioned this pull request Nov 15, 2024
Open
30 tasks
@kunga kunga marked this pull request as ready for review November 15, 2024 15:11
@kunga kunga requested a review from snaury November 15, 2024 15:14
snaury
snaury reviewed Nov 18, 2024
View reviewed changes
ydb/core/util/cache_cache.h
@@ -7,7 +7,7 @@
#include <util/generic/ptr.h>
#include <util/generic/intrlist.h>

namespace NKikimr::NCache {
namespace NKikimr::NSharedCache {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared cache - это про таблетку, а здесь в util по идее какие-то общие классы, которые в теории могут использоваться где угодно. Не понимаю почему здесь вдруг namespace NSharedCache.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот кэш никем больше не используется, и уже сильно заточен именно под реалии Shared Cache

Так что в будущем я планирую его и вовсе удалить, когда он в Shared Cache станет не нужен

@kunga kunga merged commit 006057b into ydb-platform:main Nov 18, 2024
10 checks passed
This was referenced Nov 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaury snaury snaury approved these changes

Assignees

@kunga kunga

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunga @snaury