Pass compacted pages directly to Shared Cache #11779
Conversation
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -0,0 +1,68 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
Вынос кода из shared_sausagecache.cpp
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| const TLogoBlobID metaId = pageCollection.Label(); | ||
|
|
||
| Y_ABORT_UNLESS(metaId); | ||
| Y_ABORT_IF(Collections.contains(metaId), "Only new collections can save compacted pages"); |
There was a problem hiding this comment.
Сомнительная верифайка, там точно не может быть гонки, когда эту мету уже успели зарегистрировать до того как этот TEvSaveCompactedPages отправился? К сожалению не вижу как это сообщение используется.
There was a problem hiding this comment.
Отправка вот https://github.com/ydb-platform/ydb/pull/11779/files#diff-fda9484ae1850f6173959c26bb38ec82f2e846b002e247b879051ee9c3546c9bR340 в момент когда формируются результаты компакшена, таблетка их получит уже потом вот тут
ydb/ydb/core/tablet_flat/flat_executor.cpp
Line 1393 in 205cf3a
TEvAttach
То есть Send(TEvSaveCompactedPages) от TOpsCompact точно будет раньше чем Send(TEvAttach) таблетки, так что как будто и сообщения в том же порядке должны приходить
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Additional information
As a first step of removing Private Cache Share Body logic, stop using it for compacted pages