Skip to content

Remove passing part pages on part switch #11952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

kunga
Copy link
Member

@kunga kunga commented Nov 25, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

As a second step of removing Private Cache Share Body logic, remove pages passing from protobufs

Copy link

github-actions bot commented Nov 25, 2024

2024-11-25 14:15:39 UTC Pre-commit check linux-x86_64-release-asan for a6562e4 has started.
2024-11-25 14:15:51 UTC Artifacts will be uploaded here
2024-11-25 14:19:16 UTC ya make is running...
🟡 2024-11-25 15:38:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10501 10416 0 23 9 53

🟢 2024-11-25 15:39:14 UTC Build successful.
🟢 2024-11-25 15:39:42 UTC ydbd size 4.9 GiB changed* by -31.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a458b35 merge: a6562e4 diff diff %
ydbd size 5 284 389 392 Bytes 5 284 356 888 Bytes -31.7 KiB -0.001%
ydbd stripped size 1 359 969 968 Bytes 1 359 967 216 Bytes -2.7 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 25, 2024

2024-11-25 14:16:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for a6562e4 has started.
2024-11-25 14:16:14 UTC Artifacts will be uploaded here
2024-11-25 14:19:31 UTC ya make is running...
🟡 2024-11-25 15:21:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26256 23411 0 14 2718 113

2024-11-25 15:23:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-25 15:35:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
128 (only retried tests) 17 0 0 2 109

🟢 2024-11-25 15:35:09 UTC Build successful.
🟢 2024-11-25 15:35:27 UTC ydbd size 2.5 GiB changed* by -6.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a458b35 merge: a6562e4 diff diff %
ydbd size 2 690 088 296 Bytes 2 690 081 664 Bytes -6.5 KiB -0.000%
ydbd stripped size 482 185 808 Bytes 482 188 048 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga self-assigned this Nov 26, 2024
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 11:06:19 UTC Pre-commit check linux-x86_64-release-asan for e71cbac has started.
2024-11-27 11:06:30 UTC Artifacts will be uploaded here
2024-11-27 11:09:25 UTC ya make is running...
🟡 2024-11-27 12:40:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13538 13466 0 16 5 51

🟢 2024-11-27 12:41:10 UTC Build successful.
🟢 2024-11-27 12:41:37 UTC ydbd size 4.9 GiB changed* by -40.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3801e16 merge: e71cbac diff diff %
ydbd size 5 293 475 952 Bytes 5 293 434 648 Bytes -40.3 KiB -0.001%
ydbd stripped size 1 360 856 656 Bytes 1 360 853 200 Bytes -3.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 11:07:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for e71cbac has started.
2024-11-27 11:08:26 UTC Artifacts will be uploaded here
2024-11-27 11:11:48 UTC ya make is running...
🟢 2024-11-27 12:20:28 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21229 19719 0 0 1397 113

🟢 2024-11-27 12:22:09 UTC Build successful.
🟢 2024-11-27 12:22:26 UTC ydbd size 2.5 GiB changed* by -10.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3801e16 merge: e71cbac diff diff %
ydbd size 2 694 276 744 Bytes 2 694 265 824 Bytes -10.7 KiB -0.000%
ydbd stripped size 482 112 560 Bytes 482 114 224 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga marked this pull request as ready for review November 27, 2024 15:04
@kunga kunga requested a review from snaury November 27, 2024 15:05
@kunga kunga merged commit 0cbe1e0 into ydb-platform:main Nov 27, 2024
11 checks passed
@kunga kunga mentioned this pull request Nov 27, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants