Skip to content

schemeshard: remove schemeshard_utils.h from common dependencies #12012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Nov 26, 2024

Remove schemeshard_utils.h from schemeshard_impl.h includes.
Move TShardDeleter and TSelfPinger out of schemeshard_utils.*.

This is part of "improve schemeshard operation build-time" effort (#10633).

Changelog category

  • Not for changelog

@ijon ijon force-pushed the schemeshard-reduce-schemeshard_utils.h-usage branch from 2ed92b1 to f9365a7 Compare November 26, 2024 13:54
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 26, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 26, 2024
@ijon ijon force-pushed the schemeshard-reduce-schemeshard_utils.h-usage branch from f9365a7 to bd54d2c Compare November 26, 2024 17:39
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 26, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 26, 2024

This comment was marked as outdated.

This comment was marked as outdated.

@ijon ijon requested a review from CyberROFL November 26, 2024 20:38
@ijon ijon force-pushed the schemeshard-reduce-schemeshard_utils.h-usage branch from e2faa05 to 73002fa Compare November 27, 2024 09:23

This comment was marked as outdated.

This comment was marked as outdated.

@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 27, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 27, 2024
…ncies

Also move TShardDeleter and TSelfPinger out of schemeshard_utils.*.
And remove schemeshard_utils.h from schemeshard_impl.h includes.
@ijon ijon force-pushed the schemeshard-reduce-schemeshard_utils.h-usage branch from 73002fa to a3b6dec Compare November 27, 2024 13:52
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 13:55:49 UTC Pre-commit check linux-x86_64-release-asan for 9cd0ccb has started.
2024-11-27 13:56:01 UTC Artifacts will be uploaded here
2024-11-27 13:59:00 UTC ya make is running...
🟡 2024-11-27 15:06:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13211 13136 0 15 10 50

🟢 2024-11-27 15:07:36 UTC Build successful.
🟡 2024-11-27 15:08:08 UTC ydbd size 4.9 GiB changed* by +187.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e89b8d6 merge: 9cd0ccb diff diff %
ydbd size 5 293 665 816 Bytes 5 293 857 592 Bytes +187.3 KiB +0.004%
ydbd stripped size 1 360 902 544 Bytes 1 360 907 824 Bytes +5.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 13:56:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9cd0ccb has started.
2024-11-27 13:56:48 UTC Artifacts will be uploaded here
2024-11-27 13:59:42 UTC ya make is running...
🟢 2024-11-27 14:52:24 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20895 19385 0 0 1396 114

🟢 2024-11-27 14:54:02 UTC Build successful.
🟡 2024-11-27 14:54:20 UTC ydbd size 2.5 GiB changed* by +118.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e89b8d6 merge: 9cd0ccb diff diff %
ydbd size 2 694 386 536 Bytes 2 694 508 240 Bytes +118.9 KiB +0.005%
ydbd stripped size 482 132 592 Bytes 482 133 936 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon merged commit bb312c5 into ydb-platform:main Nov 27, 2024
10 checks passed
@ijon ijon deleted the schemeshard-reduce-schemeshard_utils.h-usage branch November 27, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants