24-3-13-hotfix: Fix bulk operations breaking frozen locks

[snaury]

Changelog entry

Fix bulk operations potentially breaking frozen locks later causing non-serializable commits.

Changelog category

• Bugfix

Additional information

While investigating YDBREQUESTS-4711 it was discovered that TTL (and bulk operations in general) are not waiting for the pipeline to be properly restored after a restart, which allowed them to erroneously break validated (and frozen) locks. This in turn could allow later transactions to violate serializability, which is demonstrated in a unit-test.

Additionally a typo was found in locks.h which caused persistent locks to always restore as read-write locks, even when they are write-only. This could never cause serializability issues, but could cause unnecessary conflicts.

[github-actions]

⚪ 2024-11-26 15:17:20 UTC Pre-commit check for 7ef15c3 has started.
⚪ 2024-11-26 15:19:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-26 16:03:31 UTC Build successful.
⚪ 2024-11-26 16:03:48 UTC Tests are running...
🔴 2024-11-26 17:28:12 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
14629	13265	0	21	1303	40

🟢 2024-11-26 17:29:05 UTC ydbd size 8.3 GiB changed* by +15.5 KiB, which is < 100.0 KiB vs stable-24-3-13-hotfix: OK

ydbd size dash	stable-24-3-13-hotfix: a2d636e	merge: 7ef15c3	diff	diff %
ydbd size	8 861 024 888 Bytes	8 861 040 768 Bytes	+15.5 KiB	+0.000%
ydbd stripped size	483 749 064 Bytes	483 749 640 Bytes	+576 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2024-11-26 15:17:55 UTC Pre-commit check for 7ef15c3 has started.
⚪ 2024-11-26 15:20:30 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-26 15:30:39 UTC Build successful.

[github-actions]

⚪ 2024-11-26 15:19:00 UTC Pre-commit check for 7ef15c3 has started.
⚪ 2024-11-26 15:21:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-26 15:49:11 UTC Build successful.
⚪ 2024-11-26 15:49:30 UTC Tests are running...
🔴 2024-11-26 18:01:24 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
10331	10227	0	33	26	45

🟢 2024-11-26 18:02:12 UTC ydbd size 5.6 GiB changed* by +11.3 KiB, which is < 100.0 KiB vs stable-24-3-13-hotfix: OK

ydbd size dash	stable-24-3-13-hotfix: 5199bc6	merge: 7ef15c3	diff	diff %
ydbd size	5 992 864 072 Bytes	5 992 875 672 Bytes	+11.3 KiB	+0.000%
ydbd stripped size	1 501 958 816 Bytes	1 501 960 160 Bytes	+1.3 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}