Skip to content

Additional validation for s3 reads/writes #12082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

evanevanevanevannnn
Copy link
Collaborator

@evanevanevanevannnn evanevanevanevannnn commented Nov 28, 2024

Changelog entry

Additional validation for s3 writes, double optional types are now explicitly unsupported

fix for YQ-1992

Changelog category

  • Improvement

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 09:06:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5d1813f has started.
2024-11-28 09:06:12 UTC Artifacts will be uploaded here
2024-11-28 09:09:18 UTC ya make is running...
🟡 2024-11-28 10:13:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30070 27232 0 2 2718 118

2024-11-28 10:15:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-28 10:29:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
733 (only retried tests) 623 0 1 1 108

2024-11-28 10:29:35 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-28 10:43:38 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
626 (only retried tests) 519 0 1 0 106

🟢 2024-11-28 10:43:50 UTC Build successful.
🟢 2024-11-28 10:44:11 UTC ydbd size 2.5 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 31e0e46 merge: 5d1813f diff diff %
ydbd size 2 695 008 432 Bytes 2 695 012 928 Bytes +4.4 KiB +0.000%
ydbd stripped size 482 192 560 Bytes 482 193 136 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 09:06:15 UTC Pre-commit check linux-x86_64-release-asan for 5d1813f has started.
2024-11-28 09:06:26 UTC Artifacts will be uploaded here
2024-11-28 09:09:20 UTC ya make is running...
🟡 2024-11-28 10:29:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12937 12864 0 12 6 55

🟢 2024-11-28 10:30:34 UTC Build successful.
🟡 2024-11-28 10:31:06 UTC ydbd size 4.9 GiB changed* by +200.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bf6d055 merge: 5d1813f diff diff %
ydbd size 5 294 621 088 Bytes 5 294 826 792 Bytes +200.9 KiB +0.004%
ydbd stripped size 1 361 097 392 Bytes 1 361 156 080 Bytes +57.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 11:19:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6f76801 has started.
2024-11-28 11:19:40 UTC Artifacts will be uploaded here
2024-11-28 11:22:43 UTC ya make is running...
2024-11-28 11:36:03 UTC Check cancelled

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 11:19:36 UTC Pre-commit check linux-x86_64-release-asan for 6f76801 has started.
2024-11-28 11:19:47 UTC Artifacts will be uploaded here
2024-11-28 11:22:42 UTC ya make is running...
2024-11-28 11:36:02 UTC Check cancelled

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 11:37:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8e85a8d has started.
2024-11-28 11:39:56 UTC Check cancelled

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 11:43:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for b7c12a3 has started.
2024-11-28 11:43:41 UTC Artifacts will be uploaded here
2024-11-28 11:46:37 UTC ya make is running...
2024-11-28 12:38:01 UTC Check cancelled

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 11:44:02 UTC Pre-commit check linux-x86_64-release-asan for b7c12a3 has started.
2024-11-28 11:44:44 UTC Artifacts will be uploaded here
2024-11-28 11:48:20 UTC ya make is running...
2024-11-28 12:38:03 UTC Check cancelled

@evanevanevanevannnn evanevanevanevannnn changed the title Additional validation for s3 datasinks Additional validation for s3 reads/writes Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 12:40:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc9684b has started.
2024-11-28 12:40:55 UTC Artifacts will be uploaded here
2024-11-28 12:44:08 UTC ya make is running...
🟡 2024-11-28 13:44:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30671 27835 0 1 2718 117

2024-11-28 13:47:18 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-28 13:58:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
825 (only retried tests) 716 0 0 1 108

🟢 2024-11-28 13:58:59 UTC Build successful.
🟢 2024-11-28 13:59:19 UTC ydbd size 2.5 GiB changed* by +22.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 97c9f43 merge: fc9684b diff diff %
ydbd size 2 686 355 384 Bytes 2 686 378 176 Bytes +22.3 KiB +0.001%
ydbd stripped size 482 203 696 Bytes 482 206 832 Bytes +3.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 12:41:40 UTC Pre-commit check linux-x86_64-release-asan for fc9684b has started.
2024-11-28 12:42:01 UTC Artifacts will be uploaded here
2024-11-28 12:45:11 UTC ya make is running...
🟡 2024-11-28 13:54:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13339 13256 0 26 9 48

🟢 2024-11-28 13:55:53 UTC Build successful.
🟢 2024-11-28 13:56:23 UTC ydbd size 4.9 GiB changed* by -13.6 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a02f6d5 merge: fc9684b diff diff %
ydbd size 5 294 884 792 Bytes 5 280 647 400 Bytes -13.6 MiB -0.269%
ydbd stripped size 1 361 164 464 Bytes 1 361 203 888 Bytes +38.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@evanevanevanevannnn evanevanevanevannnn merged commit 6067a04 into ydb-platform:main Nov 28, 2024
10 checks passed
@evanevanevanevannnn evanevanevanevannnn deleted the YQ_1992_fix branch November 28, 2024 14:11
GrigoriyPA pushed a commit to GrigoriyPA/ydb that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants