Skip to content

Make it possible to change in-memory setting for tables #12099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

Make it possible to change in-memory setting for tables #12099

merged 1 commit into from
Nov 29, 2024

Conversation

snaury
Copy link
Member

@snaury snaury commented Nov 28, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

An unsafe and unsupported feature (in-memory tables) turned out to be too difficult to use in practice. Allow changing this setting for existing tables and make it easier to do so with a C++ client. Additionally enabling in-memory mode for already running tables didn't do anything until reboot, as well as didn't work properly on followers, those deficiencies are fixed.

Fixes #12010.

@snaury snaury self-assigned this Nov 28, 2024
@snaury snaury force-pushed the feature-12010-allow-keep-in-memory-alter-family branch from 7978fd7 to db635ac Compare November 28, 2024 13:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 13:36:38 UTC Pre-commit check linux-x86_64-release-asan for 547e5d1 has started.
⚪ 2024-11-28 13:36:49 UTC Artifacts will be uploaded here
⚪ 2024-11-28 13:39:53 UTC ya make is running...
⚫ 2024-11-28 14:29:20 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 13:39:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 547e5d1 has started.
⚪ 2024-11-28 13:39:21 UTC Artifacts will be uploaded here
⚪ 2024-11-28 13:42:27 UTC ya make is running...
⚫ 2024-11-28 14:29:21 UTC Check cancelled

@snaury snaury force-pushed the feature-12010-allow-keep-in-memory-alter-family branch from db635ac to f6685ae Compare November 28, 2024 14:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 14:30:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0041818 has started.
⚪ 2024-11-28 14:31:23 UTC Artifacts will be uploaded here
⚪ 2024-11-28 14:35:03 UTC ya make is running...
⚫ 2024-11-28 15:33:32 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 14:33:50 UTC Pre-commit check linux-x86_64-release-asan for 0041818 has started.
⚪ 2024-11-28 14:34:02 UTC Artifacts will be uploaded here
⚪ 2024-11-28 14:37:15 UTC ya make is running...
⚫ 2024-11-28 15:33:32 UTC Check cancelled

@snaury snaury force-pushed the feature-12010-allow-keep-in-memory-alter-family branch from f6685ae to b488c01 Compare November 28, 2024 15:33
@snaury snaury marked this pull request as ready for review November 28, 2024 15:33
@snaury snaury requested a review from kunga November 28, 2024 15:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 15:37:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1bd4963 has started.
⚪ 2024-11-28 15:37:56 UTC Artifacts will be uploaded here
⚪ 2024-11-28 15:41:16 UTC ya make is running...
🟡 2024-11-28 16:59:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32745 29909 0 4 2719 113

⚪ 2024-11-28 17:02:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-28 17:14:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
743 (only retried tests) 634 0 2 0 107

⚪ 2024-11-28 17:14:58 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-28 17:26:24 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
636 (only retried tests) 528 0 2 0 106

🟢 2024-11-28 17:26:34 UTC Build successful.
🟢 2024-11-28 17:26:53 UTC ydbd size 2.5 GiB changed* by +10.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2f89980 merge: 1bd4963 diff diff %
ydbd size 2 686 661 376 Bytes 2 686 671 584 Bytes +10.0 KiB +0.000%
ydbd stripped size 482 255 888 Bytes 482 257 552 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 15:37:45 UTC Pre-commit check linux-x86_64-release-asan for 1bd4963 has started.
⚪ 2024-11-28 15:37:57 UTC Artifacts will be uploaded here
⚪ 2024-11-28 15:41:19 UTC ya make is running...
🟡 2024-11-28 17:09:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15378 15300 0 22 6 50

🟢 2024-11-28 17:10:21 UTC Build successful.
🟢 2024-11-28 17:10:49 UTC ydbd size 4.9 GiB changed* by +27.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2f89980 merge: 1bd4963 diff diff %
ydbd size 5 281 015 488 Bytes 5 281 044 016 Bytes +27.9 KiB +0.001%
ydbd stripped size 1 361 303 664 Bytes 1 361 314 096 Bytes +10.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

kunga
kunga reviewed Nov 28, 2024
View reviewed changes
kunga
kunga previously approved these changes Nov 28, 2024
View reviewed changes
@snaury snaury force-pushed the feature-12010-allow-keep-in-memory-alter-family branch from b488c01 to fee94af Compare November 29, 2024 08:08
@snaury snaury requested a review from kunga November 29, 2024 08:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

⚪ 2024-11-29 08:12:53 UTC Pre-commit check linux-x86_64-release-asan for 9e31f54 has started.
⚪ 2024-11-29 08:13:05 UTC Artifacts will be uploaded here
⚪ 2024-11-29 08:16:31 UTC ya make is running...
🟡 2024-11-29 09:47:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15377 15310 0 9 10 48

🟢 2024-11-29 09:49:11 UTC Build successful.
🟢 2024-11-29 09:49:38 UTC ydbd size 4.9 GiB changed* by -6.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9a20a06 merge: 9e31f54 diff diff %
ydbd size 5 281 104 184 Bytes 5 281 097 288 Bytes -6.7 KiB -0.000%
ydbd stripped size 1 361 318 832 Bytes 1 361 318 960 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

⚪ 2024-11-29 08:13:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9e31f54 has started.
⚪ 2024-11-29 08:13:27 UTC Artifacts will be uploaded here
⚪ 2024-11-29 08:16:38 UTC ya make is running...
🟡 2024-11-29 09:37:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32774 29943 0 1 2719 111

⚪ 2024-11-29 09:39:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-29 09:51:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
740 (only retried tests) 631 0 0 1 108

🟢 2024-11-29 09:51:51 UTC Build successful.
🟢 2024-11-29 09:52:08 UTC ydbd size 2.5 GiB changed* by +432 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9a20a06 merge: 9e31f54 diff diff %
ydbd size 2 686 697 448 Bytes 2 686 697 880 Bytes +432 Bytes +0.000%
ydbd stripped size 482 258 800 Bytes 482 259 056 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury merged commit 38aef7d into ydb-platform:main Nov 29, 2024
10 checks passed
@snaury snaury deleted the feature-12010-allow-keep-in-memory-alter-family branch November 29, 2024 10:36
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 29, 2024
Merged
snaury added a commit to snaury/ydb that referenced this pull request Nov 29, 2024
@snaury
Make it possible to change in-memory setting for tables (ydb-platform…
4221c26 
…#12099)
@naspirato naspirato mentioned this pull request Dec 1, 2024
Open
@GrigoriyPA GrigoriyPA mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunga kunga kunga approved these changes

Assignees

@snaury snaury

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow enabling keep_in_memory with a column family alter table
2 participants
@snaury @kunga