Skip to content

Add a feature flag for disabling erase cache #12931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

snaury
Copy link
Member

@snaury snaury commented Dec 24, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

We need a way to disable erase cache for certain databases to verify whether it introduces problems or not.

@snaury snaury self-assigned this Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 14:42:59 UTC Pre-commit check linux-x86_64-release-asan for f989ce6 has started.
2024-12-24 14:43:37 UTC Check cancelled

@snaury snaury force-pushed the allow-disabling-erase-cache branch from 8a350ac to dd97dd1 Compare December 24, 2024 14:43
Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 14:46:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4c6aec4 has started.
2024-12-24 14:46:26 UTC Artifacts will be uploaded here
2024-12-24 14:49:45 UTC ya make is running...
🔴 2024-12-24 14:52:46 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 14:46:21 UTC Pre-commit check linux-x86_64-release-asan for 4c6aec4 has started.
2024-12-24 14:46:34 UTC Artifacts will be uploaded here
2024-12-24 14:50:04 UTC ya make is running...
🔴 2024-12-24 14:53:19 UTC Build failed, see the logs. Also see fail summary

@snaury snaury force-pushed the allow-disabling-erase-cache branch from dd97dd1 to fb0fef4 Compare December 24, 2024 15:25
Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 15:29:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for f593f30 has started.
2024-12-24 15:29:51 UTC Artifacts will be uploaded here
2024-12-24 15:33:04 UTC ya make is running...
🟡 2024-12-24 17:01:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31012 28011 0 7 2875 119

2024-12-24 17:05:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-24 17:20:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 103 0 0 0 117

🟢 2024-12-24 17:20:56 UTC Build successful.
🟢 2024-12-24 17:21:14 UTC ydbd size 2.1 GiB changed* by +3.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ed24bb6 merge: f593f30 diff diff %
ydbd size 2 235 384 768 Bytes 2 235 388 040 Bytes +3.2 KiB +0.000%
ydbd stripped size 478 084 336 Bytes 478 084 912 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 15:29:28 UTC Pre-commit check linux-x86_64-release-asan for f593f30 has started.
2024-12-24 15:29:40 UTC Artifacts will be uploaded here
2024-12-24 15:33:00 UTC ya make is running...
🟡 2024-12-24 17:14:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14068 13977 0 26 10 55

🟢 2024-12-24 17:15:59 UTC Build successful.
🟢 2024-12-24 17:16:23 UTC ydbd size 3.6 GiB changed* by +5.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ed24bb6 merge: f593f30 diff diff %
ydbd size 3 866 354 920 Bytes 3 866 360 320 Bytes +5.3 KiB +0.000%
ydbd stripped size 1 351 005 568 Bytes 1 351 006 528 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review December 24, 2024 17:36
@snaury snaury requested a review from azevaykin December 24, 2024 17:37
@snaury snaury merged commit 1a7266c into ydb-platform:main Dec 25, 2024
13 checks passed
@snaury snaury deleted the allow-disabling-erase-cache branch December 25, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants