Skip to content

Kafka connect distributed #12960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Mar 12, 2025
Merged

Kafka connect distributed #12960

merged 22 commits into from
Mar 12, 2025

Conversation

niksaveliev
Copy link
Collaborator

@niksaveliev niksaveliev commented Dec 25, 2024 •
edited
Loading

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 00:57:28 UTC Pre-commit check linux-x86_64-release-asan for ee21fbe has started.
⚪ 2024-12-25 00:57:41 UTC Artifacts will be uploaded here
⚪ 2024-12-25 01:00:09 UTC ya make is running...
🟢 2024-12-25 01:00:15 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-25 01:00:20 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 00:58:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for ee21fbe has started.
⚪ 2024-12-25 00:58:22 UTC Artifacts will be uploaded here
⚪ 2024-12-25 01:00:48 UTC ya make is running...
🟢 2024-12-25 01:00:53 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-25 01:00:59 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 07:24:15 UTC Pre-commit check linux-x86_64-release-asan for e106f83 has started.
⚪ 2024-12-25 07:24:28 UTC Artifacts will be uploaded here
⚪ 2024-12-25 07:26:58 UTC ya make is running...
🟢 2024-12-25 07:27:04 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-25 07:27:09 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 07:26:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for e106f83 has started.
⚪ 2024-12-25 07:26:39 UTC Artifacts will be uploaded here
⚪ 2024-12-25 07:28:59 UTC ya make is running...
🟢 2024-12-25 07:29:05 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-25 07:29:10 UTC Build successful.

a-serebryanskiy
a-serebryanskiy reviewed Feb 6, 2025
View reviewed changes
@niksaveliev niksaveliev force-pushed the kafka-connect-distributed branch from 401b07f to 3326085 Compare February 12, 2025 23:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

⚪ 2025-02-12 23:23:20 UTC Pre-commit check linux-x86_64-release-asan for 9f78b74 has started.
⚪ 2025-02-12 23:23:32 UTC Artifacts will be uploaded here
⚪ 2025-02-12 23:26:37 UTC ya make is running...
🔴 2025-02-12 23:41:47 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

⚪ 2025-02-12 23:23:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9f78b74 has started.
⚪ 2025-02-12 23:23:38 UTC Artifacts will be uploaded here
⚪ 2025-02-12 23:26:43 UTC ya make is running...
🔴 2025-02-12 23:46:01 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 13:13:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for b09a58c has started.
⚪ 2025-02-13 13:13:42 UTC Artifacts will be uploaded here
⚪ 2025-02-13 13:16:49 UTC ya make is running...
🔴 2025-02-13 13:19:28 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 13:18:50 UTC Pre-commit check linux-x86_64-release-asan for b09a58c has started.
⚪ 2025-02-13 13:19:02 UTC Artifacts will be uploaded here
⚪ 2025-02-13 13:22:10 UTC ya make is running...
🔴 2025-02-13 13:25:10 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 23:31:27 UTC Pre-commit check linux-x86_64-release-asan for 11bd6f4 has started.
⚪ 2025-02-13 23:31:40 UTC Artifacts will be uploaded here
⚪ 2025-02-13 23:34:46 UTC ya make is running...
🔴 2025-02-13 23:37:40 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 23:31:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 11bd6f4 has started.
⚪ 2025-02-13 23:31:45 UTC Artifacts will be uploaded here
⚪ 2025-02-13 23:34:59 UTC ya make is running...
🔴 2025-02-13 23:38:24 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2025 •
edited
Loading

⚪ 2025-02-16 21:54:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for dc02628 has started.
⚪ 2025-02-16 21:54:14 UTC Artifacts will be uploaded here
⚪ 2025-02-16 21:57:37 UTC ya make is running...
⚫ 2025-02-16 23:16:44 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2025 •
edited
Loading

⚪ 2025-02-16 21:58:45 UTC Pre-commit check linux-x86_64-release-asan for dc02628 has started.
⚪ 2025-02-16 21:58:56 UTC Artifacts will be uploaded here
⚪ 2025-02-16 22:02:03 UTC ya make is running...
⚫ 2025-02-16 23:16:45 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2025 •
edited
Loading

⚪ 2025-02-16 23:18:15 UTC Pre-commit check linux-x86_64-release-asan for a59cadd has started.
⚪ 2025-02-16 23:18:27 UTC Artifacts will be uploaded here
⚪ 2025-02-16 23:21:45 UTC ya make is running...
🟡 2025-02-17 00:38:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13764 13636 0 73 16 39

⚪ 2025-02-17 00:39:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-17 00:56:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
180 (only retried tests) 137 0 5 5 33

⚪ 2025-02-17 00:56:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-17 01:08:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75 (only retried tests) 35 0 4 3 33

🟢 2025-02-17 01:08:32 UTC Build successful.
🟡 2025-02-17 01:09:03 UTC ydbd size 3.6 GiB changed* by +1.7 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7c2a68c merge: a59cadd diff diff %
ydbd size 3 889 415 240 Bytes 3 891 153 728 Bytes +1.7 MiB +0.045%
ydbd stripped size 1 361 429 552 Bytes 1 361 760 816 Bytes +323.5 KiB +0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2025 •
edited
Loading

⚪ 2025-02-16 23:22:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for a59cadd has started.
⚪ 2025-02-16 23:23:58 UTC Artifacts will be uploaded here
⚪ 2025-02-16 23:27:07 UTC ya make is running...
🟡 2025-02-17 00:24:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27980 25318 0 65 2460 137

⚪ 2025-02-17 00:26:33 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-17 00:57:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
277 (only retried tests) 148 0 0 1 128

🟢 2025-02-17 00:57:39 UTC Build successful.
🟡 2025-02-17 00:57:58 UTC ydbd size 2.1 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7c2a68c merge: a59cadd diff diff %
ydbd size 2 235 932 952 Bytes 2 237 038 608 Bytes +1.1 MiB +0.049%
ydbd stripped size 473 766 104 Bytes 473 890 040 Bytes +121.0 KiB +0.026%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@niksaveliev niksaveliev marked this pull request as ready for review February 17, 2025 07:26
@niksaveliev niksaveliev requested a review from a team as a code owner February 17, 2025 07:26
alexnick88
alexnick88 reviewed Feb 17, 2025
View reviewed changes
ydb/core/kafka_proxy/actors/kafka_balancer_actor.cpp Outdated
NKqp::TEvKqp::TEvQueryResponse::TPtr ev,
const TActorContext& ctx
) {
switch (CurrentStep) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check in Y_FAIL_UNLESS that ev == nullptr only for correct states, where no members of ev are used

a-serebryanskiy
a-serebryanskiy previously approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@a-serebryanskiy a-serebryanskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Имхо все хорошо, можно мерджить. Комментарии косметические

@niksaveliev niksaveliev force-pushed the kafka-connect-distributed branch from ed90574 to 4e2abd8 Compare February 24, 2025 13:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

⚪ 2025-02-24 13:16:04 UTC Pre-commit check linux-x86_64-release-asan for 980a59a has started.
⚪ 2025-02-24 13:18:09 UTC Artifacts will be uploaded here
⚪ 2025-02-24 13:21:32 UTC ya make is running...
🟡 2025-02-24 14:53:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13700 13636 0 22 9 33

⚪ 2025-02-24 14:54:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-24 15:07:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 63 0 0 3 33

🟢 2025-02-24 15:07:15 UTC Build successful.
🟡 2025-02-24 15:07:44 UTC ydbd size 3.6 GiB changed* by +1.9 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: cb5d0e3 merge: 980a59a diff diff %
ydbd size 3 899 589 992 Bytes 3 901 550 568 Bytes +1.9 MiB +0.050%
ydbd stripped size 1 365 211 408 Bytes 1 365 603 984 Bytes +383.4 KiB +0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

⚪ 2025-02-24 13:16:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 980a59a has started.
⚪ 2025-02-24 13:16:34 UTC Artifacts will be uploaded here
⚪ 2025-02-24 13:19:55 UTC ya make is running...
🟡 2025-02-24 14:56:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28077 25478 0 1 2461 137

⚪ 2025-02-24 14:59:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-24 15:12:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
203 (only retried tests) 76 0 0 1 126

🟢 2025-02-24 15:12:49 UTC Build successful.
🟡 2025-02-24 15:13:08 UTC ydbd size 2.1 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: cb5d0e3 merge: 980a59a diff diff %
ydbd size 2 242 886 232 Bytes 2 244 091 536 Bytes +1.1 MiB +0.054%
ydbd stripped size 474 869 016 Bytes 475 005 080 Bytes +132.9 KiB +0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 22:42:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 378da58 has started.
⚪ 2025-02-25 22:42:23 UTC Artifacts will be uploaded here
⚪ 2025-02-25 22:45:36 UTC ya make is running...
🟡 2025-02-26 00:14:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28085 25483 0 4 2462 136

⚪ 2025-02-26 00:16:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 00:35:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
209 (only retried tests) 80 0 0 0 129

🟢 2025-02-26 00:35:16 UTC Build successful.
🟡 2025-02-26 00:35:35 UTC ydbd size 2.1 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 38b28a9 merge: 378da58 diff diff %
ydbd size 2 243 348 776 Bytes 2 244 698 336 Bytes +1.3 MiB +0.060%
ydbd stripped size 474 924 472 Bytes 475 067 000 Bytes +139.2 KiB +0.030%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 14:26:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for f80ee10 has started.
⚪ 2025-03-05 14:26:41 UTC Artifacts will be uploaded here
⚪ 2025-03-05 14:29:55 UTC ya make is running...
🟡 2025-03-05 16:01:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28136 25532 0 4 2477 123

⚪ 2025-03-05 16:03:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-05 16:15:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 82 0 0 0 110

🟢 2025-03-05 16:15:52 UTC Build successful.
🟡 2025-03-05 16:16:14 UTC ydbd size 2.1 GiB changed* by +1.4 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 347babc merge: f80ee10 diff diff %
ydbd size 2 293 666 448 Bytes 2 295 124 984 Bytes +1.4 MiB +0.064%
ydbd stripped size 480 336 480 Bytes 480 494 240 Bytes +154.1 KiB +0.033%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 14:26:50 UTC Pre-commit check linux-x86_64-release-asan for f80ee10 has started.
⚪ 2025-03-05 14:27:12 UTC Artifacts will be uploaded here
⚪ 2025-03-05 14:30:21 UTC ya make is running...
🟡 2025-03-05 16:11:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13729 13568 0 96 29 36

⚪ 2025-03-05 16:13:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 16:27:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 172 0 9 8 31

⚪ 2025-03-05 16:28:00 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-05 16:40:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76 (only retried tests) 40 0 0 7 29

🟢 2025-03-05 16:40:11 UTC Build successful.
🔴 2025-03-05 16:40:44 UTC ydbd size 3.7 GiB changed* by +2.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 347babc merge: f80ee10 diff diff %
ydbd size 3 996 410 784 Bytes 3 998 813 616 Bytes +2.3 MiB +0.060%
ydbd stripped size 1 390 093 480 Bytes 1 390 555 112 Bytes +450.8 KiB +0.033%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 17:13:01 UTC Pre-commit check linux-x86_64-release-asan for 9157bcf has started.
⚪ 2025-03-10 17:13:30 UTC Artifacts will be uploaded here
⚪ 2025-03-10 17:17:08 UTC ya make is running...
⚫ 2025-03-10 17:34:12 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 17:15:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9157bcf has started.
⚪ 2025-03-10 17:15:33 UTC Artifacts will be uploaded here
⚪ 2025-03-10 17:18:41 UTC ya make is running...
⚫ 2025-03-10 17:34:11 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 17:37:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for c86c96c has started.
⚪ 2025-03-10 17:37:20 UTC Artifacts will be uploaded here
⚪ 2025-03-10 17:40:35 UTC ya make is running...
🟡 2025-03-10 18:57:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28211 25619 0 1 2467 124

⚪ 2025-03-10 18:59:31 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-10 19:12:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
166 (only retried tests) 55 0 0 0 111

🟢 2025-03-10 19:12:43 UTC Build successful.
🟡 2025-03-10 19:13:04 UTC ydbd size 2.1 GiB changed* by +1.4 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b212757 merge: c86c96c diff diff %
ydbd size 2 293 931 472 Bytes 2 295 378 680 Bytes +1.4 MiB +0.063%
ydbd stripped size 480 434 240 Bytes 480 599 360 Bytes +161.2 KiB +0.034%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 17:39:30 UTC Pre-commit check linux-x86_64-release-asan for c86c96c has started.
⚪ 2025-03-10 17:39:45 UTC Artifacts will be uploaded here
⚪ 2025-03-10 17:42:48 UTC ya make is running...
🟡 2025-03-10 19:07:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13798 13612 0 142 8 36

⚪ 2025-03-10 19:08:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-10 19:24:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
279 (only retried tests) 214 0 33 0 32

⚪ 2025-03-10 19:24:33 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-10 19:36:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
126 (only retried tests) 88 0 8 0 30

🟢 2025-03-10 19:36:39 UTC Build successful.
🔴 2025-03-10 19:37:07 UTC ydbd size 3.7 GiB changed* by +2.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: b212757 merge: c86c96c diff diff %
ydbd size 3 994 996 608 Bytes 3 997 384 808 Bytes +2.3 MiB +0.060%
ydbd stripped size 1 388 606 664 Bytes 1 389 074 504 Bytes +456.9 KiB +0.034%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

⚪ 2025-03-11 10:16:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4a0d6ae has started.
⚪ 2025-03-11 10:16:27 UTC Artifacts will be uploaded here
⚪ 2025-03-11 10:19:30 UTC ya make is running...
🟡 2025-03-11 11:47:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28244 25492 0 168 2461 123

⚪ 2025-03-11 11:49:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-11 12:02:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
341 (only retried tests) 231 0 0 7 103

🟢 2025-03-11 12:02:30 UTC Build successful.
🟡 2025-03-11 12:02:55 UTC ydbd size 2.1 GiB changed* by +1.4 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4880f2d merge: 4a0d6ae diff diff %
ydbd size 2 296 125 704 Bytes 2 297 568 600 Bytes +1.4 MiB +0.063%
ydbd stripped size 480 730 208 Bytes 480 891 296 Bytes +157.3 KiB +0.034%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

⚪ 2025-03-11 10:16:50 UTC Pre-commit check linux-x86_64-release-asan for 4a0d6ae has started.
⚪ 2025-03-11 10:17:06 UTC Artifacts will be uploaded here
⚪ 2025-03-11 10:20:20 UTC ya make is running...
🟡 2025-03-11 12:03:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13827 13616 0 168 10 33

⚪ 2025-03-11 12:04:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-11 12:18:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
311 (only retried tests) 203 0 70 6 32

⚪ 2025-03-11 12:18:24 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-11 12:33:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 114 0 40 2 30

🟢 2025-03-11 12:33:55 UTC Build successful.
🔴 2025-03-11 12:34:26 UTC ydbd size 3.7 GiB changed* by +2.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 4880f2d merge: 4a0d6ae diff diff %
ydbd size 3 998 881 392 Bytes 4 001 265 152 Bytes +2.3 MiB +0.060%
ydbd stripped size 1 389 593 896 Bytes 1 390 057 576 Bytes +452.8 KiB +0.033%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexnick88
alexnick88 previously approved these changes Mar 11, 2025
View reviewed changes
Alek5andr-Kotov
Alek5andr-Kotov reviewed Mar 11, 2025
View reviewed changes
ydb/core/kafka_proxy/actors/kafka_balance_actor_sql.cpp
last_heartbeat_time = $LastMasterHeartbeat,
master = $Master
WHERE database = $Database
AND consumer_group = $ConsumerGroup;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему в этом запросе нет предиката generation = $Generation?

ydb/core/kafka_proxy/kqp_balance_transaction.h

class TKqpTxHelper {
public:
TKqpTxHelper(TString database);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше сделать explicit

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

⚪ 2025-03-11 12:55:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for cf470b8 has started.
⚪ 2025-03-11 12:55:42 UTC Artifacts will be uploaded here
⚪ 2025-03-11 12:58:45 UTC ya make is running...
🟡 2025-03-11 14:23:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28247 25667 0 2 2466 112

⚪ 2025-03-11 14:26:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-11 14:39:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
156 (only retried tests) 50 0 0 0 106

🟢 2025-03-11 14:39:27 UTC Build successful.
🟡 2025-03-11 14:39:46 UTC ydbd size 2.1 GiB changed* by +1.4 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7bc905c merge: cf470b8 diff diff %
ydbd size 2 296 175 592 Bytes 2 297 618 456 Bytes +1.4 MiB +0.063%
ydbd stripped size 480 738 144 Bytes 480 899 232 Bytes +157.3 KiB +0.034%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

⚪ 2025-03-11 12:55:31 UTC Pre-commit check linux-x86_64-release-asan for cf470b8 has started.
⚪ 2025-03-11 12:55:35 UTC Artifacts will be uploaded here
⚪ 2025-03-11 12:58:40 UTC ya make is running...
🟡 2025-03-11 14:32:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13828 13644 0 137 12 35

⚪ 2025-03-11 14:33:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-11 14:48:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
273 (only retried tests) 156 0 80 5 32

⚪ 2025-03-11 14:48:19 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-11 15:01:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 108 0 50 5 31

🟢 2025-03-11 15:01:23 UTC Build successful.
🔴 2025-03-11 15:01:52 UTC ydbd size 3.7 GiB changed* by +2.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 7bc905c merge: cf470b8 diff diff %
ydbd size 3 998 958 256 Bytes 4 001 346 120 Bytes +2.3 MiB +0.060%
ydbd stripped size 1 389 613 992 Bytes 1 390 081 832 Bytes +456.9 KiB +0.034%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@niksaveliev niksaveliev merged commit f1b5df5 into ydb-platform:main Mar 12, 2025
12 checks passed
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@niksaveliev @adameat
Kafka connect distributed (ydb-platform#12960)
eb6db29
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@niksaveliev @blinkov
Kafka connect distributed (#12960)
849884d
Emgariko pushed a commit to Emgariko/ydb that referenced this pull request Mar 24, 2025
@niksaveliev @Emgariko
Kafka connect distributed (ydb-platform#12960)
d4b6730
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@niksaveliev
Kafka connect distributed (ydb-platform#12960)
6288569
niksaveliev added a commit to niksaveliev/ydb that referenced this pull request Apr 1, 2025
@niksaveliev
Kafka connect distributed (ydb-platform#12960)
2a3339f
nshestakov pushed a commit to nshestakov/ydb that referenced this pull request May 5, 2025
@niksaveliev @nshestakov
Kafka connect distributed (ydb-platform#12960)
343ad38
nshestakov pushed a commit to nshestakov/ydb that referenced this pull request May 5, 2025
@niksaveliev @nshestakov
Kafka connect distributed (ydb-platform#12960)
e6a0163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alek5andr-Kotov Alek5andr-Kotov Alek5andr-Kotov left review comments

@alexnick88 alexnick88 alexnick88 approved these changes

@a-serebryanskiy a-serebryanskiy a-serebryanskiy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niksaveliev @a-serebryanskiy @alexnick88 @Alek5andr-Kotov