Skip to content

Log last failed memory allocation instead of max #12981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lll-phill-lll
Copy link
Member

Changelog entry

Since some memory exceptions are now caught internally by the computer node, the error log becomes incorrect. The largest allocations are caught and handled, but are still logged if another error occurs, which leads to confusion.
...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@lll-phill-lll lll-phill-lll changed the title Log last failed memory allocation insted of max Log last failed memory allocation instead of max Dec 25, 2024
Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 10:37:50 UTC Pre-commit check linux-x86_64-release-asan for df114dd has started.
2024-12-25 10:38:01 UTC Artifacts will be uploaded here
2024-12-25 10:40:54 UTC ya make is running...
🟡 2024-12-25 11:47:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13768 13682 0 21 13 52

🟢 2024-12-25 11:48:23 UTC Build successful.
🟢 2024-12-25 11:48:51 UTC ydbd size 3.6 GiB changed* by -496 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d0920bc merge: df114dd diff diff %
ydbd size 3 864 670 008 Bytes 3 864 669 512 Bytes -496 Bytes -0.000%
ydbd stripped size 1 347 522 592 Bytes 1 347 522 400 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 10:37:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for df114dd has started.
2024-12-25 10:38:03 UTC Artifacts will be uploaded here
2024-12-25 10:41:02 UTC ya make is running...
🟡 2024-12-25 11:35:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20960 19417 0 4 1416 123

2024-12-25 11:37:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 11:49:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 67 0 1 0 116

2024-12-25 11:50:02 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-25 12:01:42 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
168 (only retried tests) 51 0 1 0 116

🟢 2024-12-25 12:01:49 UTC Build successful.
🟢 2024-12-25 12:02:13 UTC ydbd size 2.1 GiB changed* by -64 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d0920bc merge: df114dd diff diff %
ydbd size 2 226 054 440 Bytes 2 226 054 376 Bytes -64 Bytes -0.000%
ydbd stripped size 467 407 152 Bytes 467 407 152 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll added the rebase-and-check Rebase PR with the current base branch and check label Dec 25, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 25, 2024
Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 12:11:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 963ccdc has started.
2024-12-25 12:11:41 UTC Artifacts will be uploaded here
2024-12-25 12:14:30 UTC ya make is running...
🟡 2024-12-25 13:05:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20984 19449 0 1 1416 118

2024-12-25 13:08:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 13:19:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 55 0 1 0 116

2024-12-25 13:20:04 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-25 13:31:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
169 (only retried tests) 53 0 0 0 116

🟢 2024-12-25 13:31:42 UTC Build successful.
🟢 2024-12-25 13:32:02 UTC ydbd size 2.1 GiB changed* by -64 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 65567d3 merge: 963ccdc diff diff %
ydbd size 2 225 951 840 Bytes 2 225 951 776 Bytes -64 Bytes -0.000%
ydbd stripped size 467 346 384 Bytes 467 346 384 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 12:13:59 UTC Pre-commit check linux-x86_64-release-asan for 963ccdc has started.
2024-12-25 12:14:11 UTC Artifacts will be uploaded here
2024-12-25 12:17:02 UTC ya make is running...
🟡 2024-12-25 13:29:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13795 13709 0 24 6 56

2024-12-25 13:31:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 13:43:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
143 (only retried tests) 89 0 3 0 51

2024-12-25 13:43:45 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-25 13:55:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 51 0 2 0 49

🟢 2024-12-25 13:55:58 UTC Build successful.
🟢 2024-12-25 13:56:28 UTC ydbd size 3.6 GiB changed* by -496 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 65567d3 merge: 963ccdc diff diff %
ydbd size 3 864 403 440 Bytes 3 864 402 944 Bytes -496 Bytes -0.000%
ydbd stripped size 1 347 300 880 Bytes 1 347 300 688 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll merged commit dfda963 into ydb-platform:main Dec 25, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants