Skip to content

JsonDocument support added YQL-17658 #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2024
Merged

JsonDocument support added YQL-17658 #1306

merged 3 commits into from
Jan 30, 2024

Conversation

aakulaga-ydb
Copy link
Contributor

@aakulaga-ydb aakulaga-ydb commented Jan 25, 2024 •
edited
Loading

JsonDocument support added YQL-17658

@aakulaga-ydb aakulaga-ydb requested a review from a team as a code owner January 25, 2024 13:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

⚪ 2024-01-25 13:47:27 UTC Pre-commit check for 5c98d3c has started.
⚪ 2024-01-25 13:47:29 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-25 14:06:04 UTC Build successful.
⚪ 2024-01-25 14:06:13 UTC Tests are running...
🔴 2024-01-25 15:50:24 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60106 50819 0 1 9236 50

@aakulaga-ydb aakulaga-ydb requested a review from rvu1024 January 25, 2024 13:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

⚪ 2024-01-25 13:49:54 UTC Pre-commit check for 5c98d3c has started.
⚪ 2024-01-25 13:49:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-25 14:08:10 UTC Build successful.
⚪ 2024-01-25 14:08:25 UTC Tests are running...
🔴 2024-01-25 15:50:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15940 15858 0 12 45 25

@aakulaga-ydb
Copy link
Contributor Author

YQL-17658 fix

@aakulaga-ydb aakulaga-ydb changed the title JsonDocument support added JsonDocument support added YQL-17658 Jan 25, 2024
rvu1024
rvu1024 requested changes Jan 26, 2024
View reviewed changes
ydb/library/yql/minikql/comp_nodes/mkql_grace_join.cpp
case NUdf::EDataSlot::DyNumber:
res.IsString = true; break;
case NUdf::EDataSlot::JsonDocument:
res.IsString = true; break;
case NUdf::EDataSlot::String:
res.IsString = true; break;
case NUdf::EDataSlot::Utf8:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо убрать default из этого switch, что бы компилятор ловил появление новых типов

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Там как раз в момент появления новых типов в default срабатывает проверка. Типы там динамически передаются в виде списка типов колонок.

ydb/library/yql/minikql/comp_nodes/mkql_grace_join.cpp Outdated
Comment on lines 174 to 180
case NUdf::EDataSlot::DyNumber:
res.IsString = true; break;
case NUdf::EDataSlot::JsonDocument:
res.IsString = true; break;
case NUdf::EDataSlot::String:
res.IsString = true; break;
case NUdf::EDataSlot::Utf8:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем одинаковый код по разными case? res.IsString = true; break; можно один раз написать сразу для нескольких типов

@aakulaga-ydb aakulaga-ydb requested a review from rvu1024 January 27, 2024 15:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2024 •
edited
Loading

⚪ 2024-01-27 15:56:51 UTC Pre-commit check for 8529e26 has started.
⚪ 2024-01-27 15:56:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-27 15:58:30 UTC Build successful.
⚪ 2024-01-27 15:58:46 UTC Tests are running...
🔴 2024-01-27 17:32:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60227 50935 0 1 9254 37

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2024 •
edited
Loading

⚪ 2024-01-27 15:57:00 UTC Pre-commit check for 8529e26 has started.
⚪ 2024-01-27 15:57:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-27 15:58:40 UTC Build successful.
⚪ 2024-01-27 15:58:55 UTC Tests are running...
🔴 2024-01-27 17:40:00 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15978 15883 0 15 54 26

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

⚪ 2024-01-29 16:07:10 UTC Pre-commit check for 5190e9a has started.
⚪ 2024-01-29 16:07:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-29 16:09:00 UTC Build successful.
⚪ 2024-01-29 16:09:12 UTC Tests are running...
🔴 2024-01-29 17:49:10 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60232 50939 0 1 9262 30

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

⚪ 2024-01-29 16:07:16 UTC Pre-commit check for 5190e9a has started.
⚪ 2024-01-29 16:07:18 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-29 16:09:00 UTC Build successful.
⚪ 2024-01-29 16:09:13 UTC Tests are running...
🔴 2024-01-29 17:53:23 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15989 15873 0 25 69 22

@rvu1024 rvu1024 merged commit f09d564 into ydb-platform:main Jan 30, 2024
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
This was referenced Jan 30, 2024
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Merged
This was referenced Feb 1, 2024
Closed
Draft
This was referenced Feb 1, 2024
Merged
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvu1024 rvu1024 rvu1024 approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aakulaga-ydb @rvu1024