Skip to content

Add port_count=1 to DQ job in YT #13459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

Krock21
Copy link
Collaborator

@Krock21 Krock21 commented Jan 16, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Currently, DQ job binds on some port and expects it to be reachable from yql agent

Ideally, it should declare port_count = 1 and use the port provided by exec node

This PR adds port_count = 1 to this job to prevent it from being placed on portless exec nodes (that do not have ports)

I created an issue to ytsaurus to start using this port: ytsaurus/ytsaurus#1034

@Krock21 Krock21 requested a review from Krisha11 January 16, 2025 18:25
@Krock21 Krock21 requested a review from a team as a code owner January 16, 2025 18:25
Copy link

github-actions bot commented Jan 16, 2025

2025-01-16 18:28:59 UTC Pre-commit check linux-x86_64-release-asan for 8379d38 has started.
2025-01-16 18:29:10 UTC Artifacts will be uploaded here
2025-01-16 18:31:31 UTC ya make is running...
🟢 2025-01-16 18:33:04 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9 9 0 0 0 0

🟢 2025-01-16 18:33:11 UTC Build successful.

Copy link

github-actions bot commented Jan 16, 2025

2025-01-16 18:29:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8379d38 has started.
2025-01-16 18:29:12 UTC Artifacts will be uploaded here
2025-01-16 18:31:36 UTC ya make is running...
🟢 2025-01-16 18:32:51 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9 9 0 0 0 0

🟢 2025-01-16 18:32:57 UTC Build successful.

@Krisha11 Krisha11 requested a review from nepal January 27, 2025 10:58
@nepal nepal merged commit 3237d80 into ydb-platform:main Jan 27, 2025
14 checks passed
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants