YQL-9517: Over BlockExpandChunked #1366

MrLolthe1st · 2024-01-28T14:03:01Z

No description provided.

github-actions · 2024-01-28T14:06:18Z

⚪ 2024-01-28 14:06:18 UTC Pre-commit check for ac2b7c4 has started.
⚪ 2024-01-28 14:06:21 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-28 14:07:51 UTC Build successful.
⚪ 2024-01-28 14:08:05 UTC Tests are running...
🔴 2024-01-28 15:42:21 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
60226	50948	0	2	9254	22

github-actions · 2024-01-28T14:06:25Z

⚪ 2024-01-28 14:06:24 UTC Pre-commit check for ac2b7c4 has started.
⚪ 2024-01-28 14:06:27 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-28 14:07:57 UTC Build successful.
⚪ 2024-01-28 14:08:23 UTC Tests are running...
🔴 2024-01-28 15:44:36 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15986	15871	0	20	56	39

nepal · 2024-01-28T16:19:43Z

ydb/library/yql/providers/dq/opt/dqs_opt.cpp

-                                    .Done())
-                                .Done())
+                            .Input(ctx.Builder(node->Pos())
+                            .Callable("BlockExpandChunked").Add(0, Build<TCoToFlow>(ctx, node->Pos())


BlockExpandChunked не в этом месте надо добавлять, а когда мы expr node переписываем в mkql runtime node. Тут оно будет мешаться оптимизаторам (в частности режиму BlockEngine = auto

github-actions · 2024-02-05T13:56:40Z

⚪ 2024-02-05 13:56:40 UTC Pre-commit check for b24517e has started.
⚪ 2024-02-05 13:56:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-05 13:59:51 UTC Build successful.
⚪ 2024-02-05 14:00:05 UTC Tests are running...
🔴 2024-02-05 15:39:28 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58879	49574	0	1	9263	41

github-actions · 2024-02-05T13:57:27Z

⚪ 2024-02-05 13:57:27 UTC Pre-commit check for b24517e has started.
⚪ 2024-02-05 13:57:29 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-05 14:00:31 UTC Build successful.
⚪ 2024-02-05 14:00:43 UTC Tests are running...
🔴 2024-02-05 15:47:04 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14551	14442	0	19	59	31

nepal · 2024-02-05T14:01:50Z

ydb/library/yql/core/type_ann/type_ann_blocks.cpp

-        output = input->HeadPtr();
-        return IGraphTransformer::TStatus::Repeat;
-    }
+        auto streamItemTypes = input->Head().GetTypeAnn()->Cast<TStreamExprType>()->GetItemType()->Cast<TMultiExprType>()->GetItems();


А можно тут уменьшить копипасту - после того как ты получил itemType, у тебя код одинаковый для stream/flow

nepal · 2024-02-05T14:03:34Z

ydb/library/yql/providers/dq/opt/dqs_opt.cpp

-                                .Done())
+                            .Input(
+                                Build<TCoToFlow>(ctx, node->Pos())
+                                .Input(ctx.Builder(node->Pos()).Callable("BlockExpandChunked")


Тут не должно быть BlockExpandChunked

github-actions · 2024-02-06T07:12:21Z

⚪ 2024-02-06 07:12:20 UTC Pre-commit check for 0f07d90 has started.
⚪ 2024-02-06 07:12:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-06 07:14:56 UTC Build successful.
⚪ 2024-02-06 07:15:15 UTC Tests are running...
🔴 2024-02-06 09:01:06 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14557	14429	0	19	75	34

github-actions · 2024-02-06T07:13:39Z

⚪ 2024-02-06 07:13:38 UTC Pre-commit check for 0f07d90 has started.
⚪ 2024-02-06 07:13:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-06 07:16:45 UTC Build successful.
⚪ 2024-02-06 07:16:59 UTC Tests are running...
🔴 2024-02-06 09:03:59 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58888	49578	0	1	9276	33

* YQL-9517: Over BlockExpandChunked * next iteration * fix * move to mkql

YQL-9517: Over BlockExpandChunked

e8d78d0

MrLolthe1st requested a review from a team as a code owner January 28, 2024 14:03

nepal requested changes Jan 28, 2024

View reviewed changes

next iteration

b2b34c0

nepal requested changes Feb 5, 2024

View reviewed changes

fix

b7c4465

MrLolthe1st requested a review from nepal February 6, 2024 07:00

move to mkql

e96445f

nepal approved these changes Feb 6, 2024

View reviewed changes

MrLolthe1st merged commit 273805e into ydb-platform:main Feb 6, 2024

vitstn mentioned this pull request Feb 6, 2024

parallel for #1650

Merged

GrigoriyPA mentioned this pull request Feb 7, 2024

YQ-2819 fix forget operation timeout #1655

Merged

vitstn mentioned this pull request Feb 7, 2024

YQL-17725 drop b and t suffixes #1660

Merged

GrigoriyPA mentioned this pull request Feb 7, 2024

KqpRun add results into clear execution #1661

Merged

This was referenced Feb 7, 2024

YQL-17725 tune doc #1667

Merged

Switch pg_parser BC tests on again #1709

Merged

unmute test #1711

Merged

ildar-khisambeev mentioned this pull request Feb 8, 2024

LOGBROKER-8783 bugfix #1713

Merged

vitstn mentioned this pull request Feb 8, 2024

Mark mutable_id for YT writes #1744

Merged

niksaveliev mentioned this pull request Feb 9, 2024

Fix pq writer and few renames #1757

Merged

GrigoriyPA mentioned this pull request Feb 9, 2024

Moved optimizers from yql/providers/dq to yql/dq #1758

Merged

serbel324 mentioned this pull request Feb 9, 2024

Mute Burst Detection tests #1763

Merged

vporyadke pushed a commit to vporyadke/ydb that referenced this pull request Feb 9, 2024

YQL-9517: Over BlockExpandChunked (ydb-platform#1366)

c597b26

* YQL-9517: Over BlockExpandChunked * next iteration * fix * move to mkql

pavelvelikhov mentioned this pull request Feb 9, 2024

Cannonized two plans #1773

Merged

niksaveliev mentioned this pull request Feb 12, 2024

Workload read without consumer and metrics fixes #1792

Merged

starlinskiy mentioned this pull request Feb 12, 2024

runtime dispatching #1800

Closed

vitstn mentioned this pull request Feb 12, 2024

quick fix for column name of select version() #1801

Merged

GrigoriyPA mentioned this pull request Feb 12, 2024

YQ 2786 fix test fq restarts #1810

Merged

vitstn mentioned this pull request Feb 12, 2024

Support of database sys cache #1817

Merged

starlinskiy mentioned this pull request Feb 12, 2024

runtime dispatching (fixed) #1847

Merged

serbel324 mentioned this pull request Feb 13, 2024

Improve some headers #1877

Merged

pavelvelikhov mentioned this pull request Feb 13, 2024

Fixed a problem with simplified plan JSONs #1878

Merged

serbel324 mentioned this pull request Feb 13, 2024

Reintroduce test_helpers for ut_blobstorage #1890

Merged

This was referenced Feb 13, 2024

Case insensivity for pg_catalog tables/cluster, columns. Support of pg_class:relam, and some columns in pg_database & pg_namespace #1893

Merged

fixed pg_get_userbyid function #1936

Merged

support of AnyNonArray type, fixes for array_agg #1958

Merged

pavelvelikhov mentioned this pull request Feb 15, 2024

Fixed a problem with plans in PG ut #1974

Merged

niksaveliev mentioned this pull request Feb 16, 2024

Fix kafka with enabled proxy #2017

Merged

vitstn mentioned this pull request Feb 16, 2024

mock of savepoints #2026

Merged

GrigoriyPA mentioned this pull request Feb 26, 2024

YQ-2898 fix query failed with unknown uncommitted upload issue #2240

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YQL-9517: Over BlockExpandChunked #1366

YQL-9517: Over BlockExpandChunked #1366

MrLolthe1st commented Jan 28, 2024 •

edited

Loading

github-actions bot commented Jan 28, 2024 •

edited

Loading

github-actions bot commented Jan 28, 2024 •

edited

Loading

nepal Jan 28, 2024

github-actions bot commented Feb 5, 2024 •

edited

Loading

github-actions bot commented Feb 5, 2024 •

edited

Loading

nepal Feb 5, 2024

nepal Feb 5, 2024

github-actions bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

YQL-9517: Over BlockExpandChunked #1366

YQL-9517: Over BlockExpandChunked #1366

Conversation

MrLolthe1st commented Jan 28, 2024 • edited Loading

github-actions bot commented Jan 28, 2024 • edited Loading

github-actions bot commented Jan 28, 2024 • edited Loading

nepal Jan 28, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 5, 2024 • edited Loading

github-actions bot commented Feb 5, 2024 • edited Loading

nepal Feb 5, 2024

Choose a reason for hiding this comment

nepal Feb 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 6, 2024 • edited Loading

github-actions bot commented Feb 6, 2024 • edited Loading

MrLolthe1st commented Jan 28, 2024 •

edited

Loading

github-actions bot commented Jan 28, 2024 •

edited

Loading

github-actions bot commented Jan 28, 2024 •

edited

Loading

github-actions bot commented Feb 5, 2024 •

edited

Loading

github-actions bot commented Feb 5, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading