Skip to content

Fix shred interface in PDisk #13926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Jan 28, 2025

Changelog entry

Fix shred interface in PDisk

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Some internal interface parts for PDisk shredding logic have been changed.

Copy link

github-actions bot commented Jan 28, 2025

2025-01-28 12:44:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 68c4744 has started.
2025-01-28 12:45:12 UTC Artifacts will be uploaded here
2025-01-28 12:47:06 UTC Check cancelled

Copy link

github-actions bot commented Jan 28, 2025

2025-01-28 12:45:30 UTC Pre-commit check linux-x86_64-release-asan for 68c4744 has started.
2025-01-28 12:45:41 UTC Artifacts will be uploaded here
2025-01-28 12:47:06 UTC Check cancelled

@alexvru alexvru force-pushed the pdisk/fix-shred-interface branch 3 times, most recently from 69a5a5a to cf465d4 Compare January 28, 2025 12:48
Copy link

github-actions bot commented Jan 28, 2025

2025-01-28 12:50:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for c624e7e has started.
2025-01-28 12:50:50 UTC Artifacts will be uploaded here
2025-01-28 12:52:03 UTC Check cancelled

Copy link

github-actions bot commented Jan 28, 2025

2025-01-28 12:51:15 UTC Pre-commit check linux-x86_64-release-asan for c624e7e has started.
2025-01-28 12:51:27 UTC Artifacts will be uploaded here
2025-01-28 12:52:03 UTC Check cancelled

@alexvru alexvru force-pushed the pdisk/fix-shred-interface branch from cf465d4 to 1c323ef Compare January 28, 2025 12:51
Copy link

github-actions bot commented Jan 28, 2025

2025-01-28 12:53:26 UTC Pre-commit check linux-x86_64-release-asan for 734a6fa has started.
2025-01-28 12:53:30 UTC Artifacts will be uploaded here
2025-01-28 12:56:20 UTC ya make is running...
🟡 2025-01-28 13:55:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11975 11923 0 19 5 28

2025-01-28 13:57:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-28 14:09:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
83 (only retried tests) 54 0 2 1 26

2025-01-28 14:09:38 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-28 14:21:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51 (only retried tests) 23 0 2 1 25

🟢 2025-01-28 14:21:27 UTC Build successful.
🟢 2025-01-28 14:21:53 UTC ydbd size 3.6 GiB changed* by +35.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e756b37 merge: 734a6fa diff diff %
ydbd size 3 864 974 472 Bytes 3 865 010 544 Bytes +35.2 KiB +0.001%
ydbd stripped size 1 351 618 096 Bytes 1 351 636 400 Bytes +17.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Member

@the-ancient-1 the-ancient-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Jan 28, 2025

2025-01-28 12:55:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 734a6fa has started.
2025-01-28 12:56:11 UTC Artifacts will be uploaded here
2025-01-28 12:59:06 UTC ya make is running...
🟡 2025-01-28 15:18:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19465 18125 0 12 1192 136

2025-01-28 15:20:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-28 15:37:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
223 (only retried tests) 103 0 0 0 120

🟢 2025-01-28 15:37:24 UTC Build successful.
🟢 2025-01-28 15:37:46 UTC ydbd size 2.1 GiB changed* by +18.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e756b37 merge: 734a6fa diff diff %
ydbd size 2 224 264 464 Bytes 2 224 283 744 Bytes +18.8 KiB +0.001%
ydbd stripped size 470 251 248 Bytes 470 257 456 Bytes +6.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) January 28, 2025 14:40
@alexvru alexvru merged commit faa5f83 into ydb-platform:main Jan 28, 2025
12 checks passed
@alexvru alexvru deleted the pdisk/fix-shred-interface branch January 28, 2025 15:56
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants