CA: fix inverted condition in TInputChannelInfo::IsPaused #14094

yumkam · 2025-01-31T17:48:21Z

Grave-but-harmless: this function is only used in monitoring page for async CA, and when checkpoint are used in sync CA (this combination is not used anywhere)

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

fortunatelly, this function is only used in monitoring page for async CA, and when checkpoint is used in sync actor (this combination is not used anywhere)

github-actions · 2025-01-31T17:52:40Z

⚪ 2025-01-31 17:52:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 065967d has started.
⚪ 2025-01-31 17:53:00 UTC Artifacts will be uploaded here
⚪ 2025-01-31 17:56:22 UTC ya make is running...
⚫ 2025-01-31 18:18:45 UTC Check cancelled

github-actions · 2025-01-31T17:59:11Z

⚪ 2025-01-31 17:59:10 UTC Pre-commit check linux-x86_64-release-asan for 065967d has started.

ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h

github-actions · 2025-01-31T18:24:52Z

⚪ 2025-01-31 18:24:52 UTC Pre-commit check linux-x86_64-release-asan for 8ec920e has started.
⚪ 2025-01-31 18:26:04 UTC Artifacts will be uploaded here
⚪ 2025-01-31 18:29:10 UTC ya make is running...
🟡 2025-01-31 19:31:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11507	11421	0	32	20	34

⚪ 2025-01-31 19:33:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-31 19:45:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
129 (only retried tests)	94	0	1	5	29

⚪ 2025-01-31 19:45:39 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-31 19:57:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
60 (only retried tests)	30	0	1	2	27

🟢 2025-01-31 19:57:46 UTC Build successful.
🟢 2025-01-31 19:58:15 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `71a3ed4`	merge: `8ec920e`	diff	diff %
ydbd size	3 871 025 512 Bytes	3 871 025 416 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 353 839 216 Bytes	1 353 839 152 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-31T18:24:58Z

⚪ 2025-01-31 18:24:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8ec920e has started.

github-actions · 2025-02-03T08:34:58Z

⚪ 2025-02-03 08:34:58 UTC Pre-commit check linux-x86_64-release-asan for 65c5cf0 has started.
⚪ 2025-02-03 08:35:10 UTC Artifacts will be uploaded here
⚪ 2025-02-03 08:38:13 UTC ya make is running...
🟡 2025-02-03 09:37:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11508	11436	0	24	14	34

⚪ 2025-02-03 09:38:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-03 10:00:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
105 (only retried tests)	68	0	3	3	31

⚪ 2025-02-03 10:00:16 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-03 10:12:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
61 (only retried tests)	23	0	2	4	32

🟢 2025-02-03 10:13:01 UTC Build successful.
🟢 2025-02-03 10:13:28 UTC ydbd size 3.6 GiB changed* by -16 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `9d9a33e`	merge: `65c5cf0`	diff	diff %
ydbd size	3 864 893 776 Bytes	3 864 893 760 Bytes	-16 Bytes	-0.000%
ydbd stripped size	1 354 458 448 Bytes	1 354 458 384 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-02-03T08:36:36Z

⚪ 2025-02-03 08:36:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 65c5cf0 has started.
⚪ 2025-02-03 08:36:47 UTC Artifacts will be uploaded here
⚪ 2025-02-03 08:39:39 UTC ya make is running...
🟡 2025-02-03 09:32:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
25761	23208	0	4	2418	131

⚪ 2025-02-03 09:35:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-03 09:57:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
198 (only retried tests)	72	0	1	0	125

⚪ 2025-02-03 09:57:10 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-03 10:07:08 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
183 (only retried tests)	60	0	1	0	122

🟢 2025-02-03 10:07:22 UTC Build successful.
🟢 2025-02-03 10:07:48 UTC ydbd size 2.1 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `e122885`	merge: `65c5cf0`	diff	diff %
ydbd size	2 222 707 240 Bytes	2 222 709 176 Bytes	+1.9 KiB	+0.000%
ydbd stripped size	472 476 792 Bytes	472 477 112 Bytes	+320 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-02-04T11:05:31Z

⚪ 2025-02-04 11:05:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 441c0bc has started.
⚪ 2025-02-04 11:05:42 UTC Artifacts will be uploaded here
⚪ 2025-02-04 11:08:50 UTC ya make is running...
🟡 2025-02-04 12:06:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
25658	23101	0	10	2421	126

⚪ 2025-02-04 12:08:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-04 12:21:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
196 (only retried tests)	73	0	0	0	123

🟢 2025-02-04 12:21:30 UTC Build successful.
🟢 2025-02-04 12:21:52 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `e367c3b`	merge: `441c0bc`	diff	diff %
ydbd size	2 224 081 848 Bytes	2 224 081 848 Bytes	0 Bytes	0.000%
ydbd stripped size	472 677 368 Bytes	472 677 368 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-02-04T11:06:02Z

⚪ 2025-02-04 11:06:01 UTC Pre-commit check linux-x86_64-release-asan for 441c0bc has started.
⚪ 2025-02-04 11:06:14 UTC Artifacts will be uploaded here
⚪ 2025-02-04 11:09:10 UTC ya make is running...
🟡 2025-02-04 12:09:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11534	11476	0	18	5	35

⚪ 2025-02-04 12:10:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-04 12:22:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
88 (only retried tests)	57	0	0	5	26

🟢 2025-02-04 12:22:54 UTC Build successful.
🟢 2025-02-04 12:23:21 UTC ydbd size 3.6 GiB changed* by -16 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `e367c3b`	merge: `441c0bc`	diff	diff %
ydbd size	3 867 472 776 Bytes	3 867 472 760 Bytes	-16 Bytes	-0.000%
ydbd stripped size	1 355 263 056 Bytes	1 355 262 992 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-02-23T16:47:28Z

🟢 2025-02-23 16:47:38 UTC The validation of the Pull Request description is successful.

…rm#14094)

Fix inverted condition in IsPaused

cf2a214

fortunatelly, this function is only used in monitoring page for async CA, and when checkpoint is used in sync actor (this combination is not used anywhere)

github-actions bot added the not-for-changelog label Jan 31, 2025

yumkam marked this pull request as ready for review January 31, 2025 17:48

yumkam requested review from a team as code owners January 31, 2025 17:48

uzhastik reviewed Jan 31, 2025

View reviewed changes

ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h Outdated Show resolved Hide resolved

remove unnecessary parens

81d2398

yumkam requested a review from uzhastik February 3, 2025 08:32

yumkam added the rebase-and-check Rebase PR with the current base branch and check label Feb 3, 2025

github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 3, 2025

yumkam added the rebase-and-check Rebase PR with the current base branch and check label Feb 4, 2025

github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 4, 2025

yumkam changed the title ~~fix inverted condition in TInputChannelInfo::IsPaused~~ sync CA: fix inverted condition in TInputChannelInfo::IsPaused Feb 23, 2025

github-actions bot added not-for-changelog and removed not-for-changelog labels Feb 23, 2025

yumkam changed the title ~~sync CA: fix inverted condition in TInputChannelInfo::IsPaused~~ CA: fix inverted condition in TInputChannelInfo::IsPaused Feb 23, 2025

github-actions bot added not-for-changelog and removed not-for-changelog labels Feb 23, 2025

kardymonds approved these changes Feb 24, 2025

View reviewed changes

uzhastik approved these changes Feb 24, 2025

View reviewed changes

Hor911 approved these changes Feb 24, 2025

View reviewed changes

yumkam merged commit 4b70624 into ydb-platform:main Feb 24, 2025
26 of 28 checks passed

serbel324 mentioned this pull request Feb 25, 2025

GroupLayoutSanitizer always monitors invalid groups, add UTs #15026

Merged

GrigoriyPA mentioned this pull request Feb 25, 2025

YQ-3561 supported in memory cp storage #15031

Merged

lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025

CA: fix inverted condition in TInputChannelInfo::IsPaused (ydb-platfo…

f474c7f

…rm#14094)

GrigoriyPA mentioned this pull request Mar 4, 2025

YQ-3655 added block splitting into DQ output channel #15330

Closed

This was referenced Mar 10, 2025

Fix segfault in Group Layout Sanitizer, add stress tests with INACTIVE/FAULTY disks #15516

Merged

Add compaction selected strategy counters #15689

Merged

alexnick88 mentioned this pull request Mar 19, 2025

provide database in schemecache request #15938

Closed

blinkov pushed a commit that referenced this pull request Mar 21, 2025

CA: fix inverted condition in TInputChannelInfo::IsPaused (#14094)

f827371

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CA: fix inverted condition in TInputChannelInfo::IsPaused #14094

CA: fix inverted condition in TInputChannelInfo::IsPaused #14094

Uh oh!

yumkam commented Jan 31, 2025

Uh oh!

github-actions bot commented Jan 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 31, 2025

Uh oh!

github-actions bot commented Feb 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

CA: fix inverted condition in TInputChannelInfo::IsPaused #14094

CA: fix inverted condition in TInputChannelInfo::IsPaused #14094

Uh oh!

Conversation

yumkam commented Jan 31, 2025

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2025

Uh oh!

github-actions bot commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 23, 2025 •

edited

Loading