Skip to content

Sync EvaluteExpr execution (#11801) #14455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented Feb 11, 2025

During query compilation special subroutine called "Expression Evaluation" may be triggered (most common case is Constant Folding in query optimization phase).

It was implemented with async API and future waiting. In some rare cases (erros or failures) future was not completed and compilation hangs forever

This path removes future from call stack and replaces it with direct sync call. It requires change of internal API, it is one of the reason why this pattern was not choosed at the time of the development.

The fix was checked with load test (enabled in this PR) and by @dcherednik in manual runs.

@Hor911 Hor911 requested a review from a team as a code owner February 11, 2025 15:27
Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 15:30:31 UTC Pre-commit check for 13968db has started.
2025-02-11 15:33:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-11 16:15:20 UTC Build successful.
2025-02-11 16:15:36 UTC Tests are running...
🔴 2025-02-11 18:27:36 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39071 33789 0 18 5219 45

🟢 2025-02-11 18:28:26 UTC ydbd size 8.3 GiB changed* by -256.2 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: a254002 merge: 13968db diff diff %
ydbd size 8 874 098 288 Bytes 8 873 835 944 Bytes -256.2 KiB -0.003%
ydbd stripped size 483 816 072 Bytes 483 814 408 Bytes -1.6 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 15:31:17 UTC Pre-commit check for 13968db has started.
2025-02-11 15:33:56 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-11 16:00:14 UTC Build successful.
2025-02-11 16:00:29 UTC Tests are running...
🔴 2025-02-11 18:18:44 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10497 10398 0 31 24 44

🟢 2025-02-11 18:32:47 UTC ydbd size 5.6 GiB changed* by -66.5 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: a254002 merge: 13968db diff diff %
ydbd size 6 002 741 216 Bytes 6 002 673 088 Bytes -66.5 KiB -0.001%
ydbd stripped size 1 504 236 640 Bytes 1 504 219 584 Bytes -16.7 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit self-requested a review February 11, 2025 18:27
@gridnevvvit gridnevvvit merged commit 184f292 into ydb-platform:stable-24-3 Feb 14, 2025
6 of 10 checks passed
gridnevvvit pushed a commit to gridnevvvit/ydb that referenced this pull request Feb 20, 2025
gridnevvvit added a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants