Break loop dependency in TDataAccessorRequest destructor #14567
Conversation
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
Нужно поправить описание PR |
|
🟢 |
| @@ -414,6 +414,7 @@ Y_UNIT_TEST_SUITE(ColumnShardTiers) { | |||
| Tests::NCommon::TLoggerInit(server->GetRuntime()).Clear().SetComponents({ NKikimrServices::TX_COLUMNSHARD }, "CS").Initialize(); | |||
|
|
|||
| auto& runtime = *server->GetRuntime(); | |||
| runtime.DisableBreakOnStopCondition(); | |||
There was a problem hiding this comment.
Можешь отключить проверку через настройку CustomFinalCondition, вместо того, чтобы расширять TTestActorRuntime? Насколько я помню, ты показывал, что эта проверка прерывает отправку событий: https://github.com/ydb-platform/ydb/blob/main/ydb/core/testlib/cs_helper.cpp#L97
There was a problem hiding this comment.
Я пробовал, это не работает
There was a problem hiding this comment.
И это условие проверяется в 2 местах, я отключаю только в одном из них
There was a problem hiding this comment.
Можем тут кастомизировать CustomFinalCondition? Иначе же совсем не понятно когда задавать DisableBreakOnStopCondition, а когда CustomFinalCondition
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
Для переноса этого условия в |
Changelog entry
Optionally disable breaking message processing loop to avoid leaving unprocessed message which breaks loop dependency and thus results in memory leak
...
Changelog category
Additional information
#13514