Skip to content

fix RawBytes counter #14594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2025
Merged

fix RawBytes counter #14594

merged 2 commits into from
Feb 15, 2025

Conversation

swalrus1
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@swalrus1 swalrus1 requested review from a team as code owners February 14, 2025 16:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 16:56:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for cbdfa44 has started.
⚪ 2025-02-14 16:56:58 UTC Artifacts will be uploaded here
⚪ 2025-02-14 16:59:46 UTC ya make is running...
⚫ 2025-02-14 17:01:13 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 16:59:10 UTC Pre-commit check linux-x86_64-release-asan for cbdfa44 has started.
⚪ 2025-02-14 17:00:27 UTC Artifacts will be uploaded here
⚫ 2025-02-14 17:01:08 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 17:05:06 UTC Pre-commit check linux-x86_64-release-asan for e3b1a81 has started.
⚪ 2025-02-14 17:05:18 UTC Artifacts will be uploaded here
⚪ 2025-02-14 17:08:05 UTC ya make is running...
🟡 2025-02-14 18:08:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11681 11583 0 45 15 38

⚪ 2025-02-14 18:10:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-14 18:28:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
147 (only retried tests) 111 0 0 3 33

🟢 2025-02-14 18:28:24 UTC Build successful.
🟢 2025-02-14 18:28:48 UTC ydbd size 3.6 GiB changed* by -272 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c15923e merge: e3b1a81 diff diff %
ydbd size 3 885 196 560 Bytes 3 885 196 288 Bytes -272 Bytes -0.000%
ydbd stripped size 1 360 360 112 Bytes 1 360 359 920 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 17:15:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for e3b1a81 has started.
⚪ 2025-02-14 17:16:16 UTC Artifacts will be uploaded here
⚪ 2025-02-14 17:19:42 UTC ya make is running...
🟡 2025-02-14 18:13:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18758 17394 0 4 1225 135

⚪ 2025-02-14 18:16:41 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-14 18:39:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 90 0 1 3 126

⚪ 2025-02-14 18:39:22 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-14 18:58:48 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 61 0 1 2 126

🟢 2025-02-14 18:58:55 UTC Build successful.
🟢 2025-02-14 18:59:16 UTC ydbd size 2.1 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c15923e merge: e3b1a81 diff diff %
ydbd size 2 234 037 192 Bytes 2 234 037 144 Bytes -48 Bytes -0.000%
ydbd stripped size 474 107 800 Bytes 474 107 736 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny added the rebase-and-check Rebase PR with the current base branch and check label Feb 14, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 20:15:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1d26a41 has started.
⚪ 2025-02-14 20:15:21 UTC Artifacts will be uploaded here
⚪ 2025-02-14 20:18:07 UTC ya make is running...
🟡 2025-02-14 21:16:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18761 17416 0 4 1213 128

⚪ 2025-02-14 21:18:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-14 21:40:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
196 (only retried tests) 69 0 0 1 126

🟢 2025-02-14 21:40:41 UTC Build successful.
🟢 2025-02-14 21:40:59 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5b11bce merge: 1d26a41 diff diff %
ydbd size 2 234 045 728 Bytes 2 234 045 728 Bytes 0 Bytes 0.000%
ydbd stripped size 474 108 376 Bytes 474 108 376 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 20:15:14 UTC Pre-commit check linux-x86_64-release-asan for 1d26a41 has started.
⚪ 2025-02-14 20:16:25 UTC Artifacts will be uploaded here
⚪ 2025-02-14 20:19:11 UTC ya make is running...
🟡 2025-02-14 21:32:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11684 11549 0 88 13 34

⚪ 2025-02-14 21:33:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-14 21:45:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
177 (only retried tests) 140 0 0 4 33

🟢 2025-02-14 21:45:42 UTC Build successful.
🟢 2025-02-14 21:46:06 UTC ydbd size 3.6 GiB changed* by -272 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5b11bce merge: 1d26a41 diff diff %
ydbd size 3 885 213 984 Bytes 3 885 213 712 Bytes -272 Bytes -0.000%
ydbd stripped size 1 360 366 992 Bytes 1 360 366 800 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 mentioned this pull request Feb 14, 2025
Merged
@swalrus1 swalrus1 merged commit 709b413 into ydb-platform:main Feb 15, 2025
17 of 18 checks passed
This was referenced Feb 15, 2025
Merged
Merged
Merged
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 23, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@swalrus1
fix RawBytes counter (ydb-platform#14594)
0d21868
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@swalrus1 @blinkov
fix RawBytes counter (#14594)
9ff1261
@swalrus1 swalrus1 deleted the fix-raw-bytes-counter branch March 31, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swalrus1 @zverevgeny